Deploying helm chart with existingSecret set on postgresql.auth and using SES email does not work

[mortenmorten]

Current Behavior

Deploying helm chart with existingSecret on postgresql and using SES for email fails.

Expected Behavior

It should not fail.

Steps To Reproduce

Deploy helm chart with this customization.yml (minified)

forge:
  email:
    enabled: true
    from: [email protected]
    ses:
      region: eu-west-1

postgresql:
  host: my-postgres-instance.rds.amazonaws.com
  port: 5432
  auth:
    existingSecret: rds-creds
    database: flowforge
    username: forge
    ssl: true

gives this error:

history.go:56: [debug] getting history for release flowforge
upgrade.go:158: [debug] preparing upgrade for flowforge
Error: UPGRADE FAILED: template: flowforge/templates/secrets.yaml:1:11: executing "flowforge/templates/secrets.yaml" at <include "forge.createSecret" .>: error calling include: template: flowforge/templates/_helpers.tpl:112:46: executing "forge.createSecret" at <.Values.forge.email.smtp.existingSecret>: nil pointer evaluating interface {}.existingSecret
helm.go:84: [debug] template: flowforge/templates/secrets.yaml:1:11: executing "flowforge/templates/secrets.yaml" at <include "forge.createSecret" .>: error calling include: template: flowforge/templates/_helpers.tpl:112:46: executing "forge.createSecret" at <.Values.forge.email.smtp.existingSecret>: nil pointer evaluating interface {}.existingSecret
UPGRADE FAILED

Environment

• FlowFuse version: 2.9.0
• Node.js version:
• npm version:
• Platform/OS:
• Browser:

Linked Customers

• Kunnusta

[hardillb]

Hi, thanks for raising this we'll have a look.

[hardillb]

{{- define "forge.createSecret" -}}
{{- if not (and .Values.postgresql.auth.existingSecret 
    (not (and .Values.forge.email (not .Values.forge.email.smtp.existingSecret)))) -}}
true
{{- else -}}
false
{{- end -}}
{{- end -}}

Looks like this needs to be something like

{{- define "forge.createSecret" -}}
{{- if not (and .Values.postgresql.auth.existingSecret 
    (not (and .Values.forge.email.smtp (not .Values.forge.email.smtp.existingSecret)))) -}}
true
{{- else -}}
false
{{- end -}}
{{- end -}}

Might need an extra and block to check for email first

[hardillb]

@mortenmorten a new version of the helm chart is being released

[Shrek53]

@hardillb
Couldn't there be an option to set the "forge.createSecret" from configuration side.
And If forge.createSecret is already set explicitly then we don't redefine it or overwrite it.

The current behavior does not take into account if "forge.createSecret" is set or not

[ppawlowski]

@Shrek53 The forge.createSecret is a helper function which determines if the secret object should be or shouldn't be created based on multiple inputs. Having a single, configurable variable will increase helm chart configuration complexity.

However, as we are open to continuous improvement, feel free to raise a pull request with your proposal.