Control enabled/disabled for UI-SLIDER

[ortegafernando]

Description

Hi, why not add the control enabled/disabled feature for ui-slider? (msg.enabled TRUE/FALSE)

And why not for other nodes?

Thanks

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

[colinl]

msg.enabled boolean true/false works for me. Not TRUE/FALSE of course.
It should work the same for most, if not all, ui nodes that generate an output.

Example flow:

[{"id":"f22455a1d7ebe86c","type":"inject","z":"997da33a0beedade","name":"enable","props":[{"p":"enabled","v":"true","vt":"bool"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":190,"y":7000,"wires":[["b8507b8c4fa9309b"]]},{"id":"36a0fc86e683c938","type":"inject","z":"997da33a0beedade","name":"disable","props":[{"p":"enabled","v":"false","vt":"bool"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":190,"y":7040,"wires":[["b8507b8c4fa9309b"]]},{"id":"1badd748960885a1","type":"debug","z":"997da33a0beedade","name":"debug 31","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":660,"y":7020,"wires":[]},{"id":"bc6e1420642b3da6","type":"ui-slider","z":"997da33a0beedade","group":"4f87bd59a15b847e","name":"","label":"slider","tooltip":"","order":0,"width":0,"height":0,"passthru":false,"outs":"all","topic":"topic","topicType":"msg","thumbLabel":"true","showTicks":"always","min":0,"max":10,"step":1,"className":"","iconPrepend":"","iconAppend":"","color":"","colorTrack":"","colorThumb":"","showTextField":false,"x":470,"y":7020,"wires":[["1badd748960885a1"]]},{"id":"b8507b8c4fa9309b","type":"junction","z":"997da33a0beedade","x":340,"y":7020,"wires":[["bc6e1420642b3da6"]]},{"id":"4f87bd59a15b847e","type":"ui-group","name":"test","page":"c6ff182a4185f2f2","width":"6","height":"1","order":1,"showTitle":false,"className":"","visible":"true","disabled":"false"},{"id":"c6ff182a4185f2f2","type":"ui-page","name":"Test page","ui":"ID-BASE-1","path":"/testpage","icon":"home","layout":"grid","theme":"f9b6670b127dc219","order":2,"className":"","visible":"true","disabled":"false"},{"id":"ID-BASE-1","type":"ui-base","name":"Dashboard","path":"/dashboard","includeClientData":true,"acceptsClientConfig":["ui-control","ui-notification","ui-gauge-classic"],"titleBarStyle":"default"},{"id":"f9b6670b127dc219","type":"ui-theme","name":"FlowForge Theme","colors":{"surface":"#152a47","primary":"#005aff","bgPage":"#ffffff","groupBg":"#ffffff","groupOutline":"#cc3e3e"},"sizes":{"pagePadding":"12px","groupGap":"12px","groupBorderRadius":"4px","widgetGap":"12px"}}]

[bartbutenaers]

It should work the same for most, if not all, ui nodes

Hii @colinl,
I did not have a detailed look at this. But at first sight the msg.enabled is being handled in the ui-base code. And I don't think that piece of the base code can be overridden by a ui widget, so I would also think that it is automatically handled for all ui nodes.

But you know that the whole stores mechanism is quite complex, so indeed it might be that the msg.enabled gets lost for the slider somewhere in the backend or frontend. Don't know at the moment...

[colinl]

it might be that the msg.enabled gets lost for the slider

No, as I said, msg.enabled does work for me with the slider.

[ortegafernando]

That is good news! Thanks a lot.

I haven't tried it yet; I've only read the documentation about the slider, and I haven't seen anything about the 'enabled' option.

So, maybe it's only necessary to update the documentation?

[colinl]

Yes, I imagine a Pull Request to update the docs would be very welcome.

[ortegafernando]

I have just tried to check slider and it works perfectly. What I dont know exaclty how to do is to check if all ui nodes will behave the same.

[colinl]

The only way to be certain is to test them.

[bartbutenaers]

The only way to be certain is to test them.

In case anybody wants to support this project, by fixing this documentation issue...

As @colinl says, it should be tested for every ui widget whether it can be enabled or disabled via msg.enabled.
And then for every widget that supports it, it should be added to its documentation.

For example you can see how the documentation (see here) for the button widget looks like:

Here you can find how this is implemented in the documentation of the button widget:

controls:
    enabled:
        example: true | false
        description: Allow control over whether or not the button is clickable.

So that needs to be added to all the markdown (.md) files of all the widgets which support it.