Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: lightbulb glyph size changed mid-cycle for v5 (removed horizontal padding) #20520

Open
1 of 2 tasks
flodolo opened this issue Jan 6, 2025 · 2 comments
Open
1 of 2 tasks
Labels
bug needs-triage This bug needs to be confirmed waiting for feedback

Comments

@flodolo
Copy link

flodolo commented Jan 6, 2025

Bug description

We upgraded Font Awesome in our app on the LTS branch v5 (from 5.0.13 to 5.15.4), and noticed a misalignment with the lightbulb icon. The change is present at least in fa-solid-900.woff2 and fa-solid-900.ttf.

Looks like the change happened between 5.2.0 and 5.3.0, although it's not listed in the changelog.

Was this change done on purpose or by mistake?

Reproducible test case

Screenshots

Screenshot of the lightbulb glyph in fontforge (fa-solid-900.woff2), v5.3.0 above, v5.2.0 below

400432262-250173b3-51f0-47dc-b91c-57c7c4aed6d5

Font Awesome version

v5.15.4

Serving

Self-hosted

Implementation

CSS

Browser and Operating System

Not dependent on browser.

Web bug report checklist

  • I have included a test case because my odds go way up that the team can fix this when I do
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
@flodolo flodolo added bug needs-triage This bug needs to be confirmed labels Jan 6, 2025
@tagliala
Copy link
Member

tagliala commented Jan 6, 2025

Hi!

Thanks for being part of the Font Awesome Community.

I can confirm this changed between 5.2.0 and 5.3.0 without an entry in the changelog, sorry for that

image

The reason should be that at that time new lightbulb-* icons were introduced, like lightbulb-dollar and so the default lightbulb was fixed by removing the extra horizontal padding

Is this causing some issues?

@flodolo
Copy link
Author

flodolo commented Jan 6, 2025

Is this causing some issues?

No, we worked around it by updating the placement via CSS. Mostly wanted to confirm this might not change back to the original spacing/size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-triage This bug needs to be confirmed waiting for feedback
Projects
None yet
Development

No branches or pull requests

2 participants