Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choice of the output type of the logs #9

Open
LaurentLienhard opened this issue Jun 25, 2019 · 4 comments
Open

Choice of the output type of the logs #9

LaurentLienhard opened this issue Jun 25, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@LaurentLienhard
Copy link
Contributor

Have the choice of the destination of the logs:

  • event in eventviewer

  • file

if event in eventwiever : possibility to use an existing log or to create a specific one for the application
if file : possibility to choice format .log,.txt

@LaurentLienhard
Copy link
Contributor Author

For exemple
Log -Destination EVENT -Journal SYSTEM -Type WARN -Message "my message" -Source AD
Log -Destination FILE -FileType LOG -Type WARM -Message "my message" -Source AD -Timestamp

@LxLeChat
Copy link

we can implement a validation with a default value. Validate values could be xml,json,csv with maybe csv by default.

-OutputType [xml/Json/Csv] 

@omiossec
Copy link
Member

We may have to change the Log object.
we should manage polymorphism to use WriteMessage it can be ad-hoc polymorphism where we can just surcharge the method based on the input
or use inclusive polymorphism where Log is a generic log object and inherence

@omiossec omiossec added the enhancement New feature or request label Jul 15, 2019
@omiossec
Copy link
Member

My proposition

Create a superclass log and several inherited class

  • logWinEvent
  • logFile
  • LogJson
  • ...

This way we can handle the complexity of these different formats and we open the way to add more format later.

@omiossec omiossec self-assigned this Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants