Bug Report: Chart-Editor's playbars Open Menus without it indicating in 'Window' Dropdown

[Trofem]

Issue Checklist

• I have read the Contributing Guide
• I have checked the Issues/Discussions pages to see if my issue has already been reported
• I have properly titled my issue

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

Chart-Editor's playbars in bottom left corner opens popup menus without it indicating in 'Window' menu.

The checkmarks of corresponding menus turn on only when pressed manually on dropdown menu, isn't updating in any of playbars's pressing occurence
(variable names from ChartEditorState.hx):

playbarDifficulty (Difficulty Window)
playbarBPM (Metadata Window)

2025-02-14.19-40-34.mp4

P.S First click on inactive Window dropdown after reprodusing bug will do nothing except making check appear

Steps to Reproduce

1. Open Chart Editor
2. CTRL+Click on playbarDifficulty or playbarBPM
3. Popup menus appear
4. But when looking to 'Window' dropdown it stays unchecked.

Solution

PR #4229

[Trofem]

I just found out yesterday about this way of opening menus through bottom-left ctrl+left click action, and found bug accidentally too.
For fixing bug i think its only needed to make call of playbars also call code parts that changes state of corresponding checkmark, playbarBPM.onClick in ChartEditorState i guess. I am not that good in haxe.ui stuff, so this is my closest guess.

// line 2879:
playbarBPM.onClick = _ -> {
      if (FlxG.keys.pressed.CONTROL)
      {
        this.setToolboxState(CHART_EDITOR_TOOLBOX_METADATA_LAYOUT, true);
        /*
            Update Window's Dropdown toggle checks, 
            some kind of switch case or loop for check
       */
      }
      else
      {
        Conductor.instance.currentTimeChange.bpm += 1;
        this.refreshToolbox(CHART_EDITOR_TOOLBOX_METADATA_LAYOUT);
      }
    }

[Lasercar]

snip

Hey, thankyou for doing the legwork for this tiny issue. I'll look into fixing this.

Hmm, I'd have to add a way for it to check whether a toolbox is open or not, or a way to cancel the onchange event of the window toolbox stuff and I don't really know if there's a way or how to do either.

But then again, it's not a big deal that it just simply opens twice.

[Lasercar]

Now has a pending PR.

[amyspark-ng]

woah nice caaatch

[Trofem]

I fixed bug in #4229 (PR with changes in playbars, was required).

[Trofem]

It's a bit weird to make a public report and then have to fix it yourself later, but it is what it is.

[Trofem]

And could we change Development PR, since the current one is closed, by any chance?

[Hundrec]

We can't link your PR manually, but we can see that yours is open.