From d8267e344c4b75e14b6aca5fa763e177ec89ed3a Mon Sep 17 00:00:00 2001
From: DimitriZhurkin <dimitri.zhurkin@noblis.org>
Date: Fri, 13 Dec 2024 08:39:27 -0700
Subject: [PATCH] Add inter-boundary-component-direction-incoming-has-ipv-uri
 constraint (#930) (#994)

* Revise inter-boundary-component-has-direction constraint (#930)

* replace http with https

* apply comments

* Add inter-boundary-component-direction-incoming-has-ipv-uri constraint
---
 features/fedramp_extensions.feature           |  6 ++---
 .../ssp/xml/fedramp-ssp-example.oscal.xml     | 20 ++++++++++++++++
 ...direction-incoming-has-ipv-uri-INVALID.xml | 23 +++++++++++++++++++
 .../fedramp-external-constraints.xml          |  5 ++++
 ...t-direction-incoming-has-ipv-uri-FAIL.yaml |  8 +++++++
 ...t-direction-incoming-has-ipv-uri-PASS.yaml |  8 +++++++
 6 files changed, 67 insertions(+), 3 deletions(-)
 create mode 100644 src/validations/constraints/content/ssp-inter-boundary-component-direction-incoming-has-ipv-uri-INVALID.xml
 create mode 100644 src/validations/constraints/unit-tests/inter-boundary-component-direction-incoming-has-ipv-uri-FAIL.yaml
 create mode 100644 src/validations/constraints/unit-tests/inter-boundary-component-direction-incoming-has-ipv-uri-PASS.yaml

diff --git a/features/fedramp_extensions.feature b/features/fedramp_extensions.feature
index b056baaed..0a7a115aa 100644
--- a/features/fedramp_extensions.feature
+++ b/features/fedramp_extensions.feature
@@ -92,7 +92,6 @@ Examples:
   | has-rules-of-behavior |
   | has-security-impact-level |
   | has-security-sensitivity-level |
-  | has-separation-of-duties-matrix |
   | has-system-id |
   | has-system-name-short |
   | has-user-guide |
@@ -104,6 +103,7 @@ Examples:
   | information-type-has-confidentiality-impact |
   | information-type-has-integrity-impact |
   | information-type-system |
+  | inter-boundary-component-direction-incoming-has-ipv-uri |
   | inter-boundary-component-has-direction |
   | interconnection-direction |
   | interconnection-security |
@@ -299,8 +299,6 @@ Examples:
   | has-security-impact-level-PASS.yaml |
   | has-security-sensitivity-level-FAIL.yaml |
   | has-security-sensitivity-level-PASS.yaml |
-  | has-separation-of-duties-matrix-FAIL.yaml |
-  | has-separation-of-duties-matrix-PASS.yaml |
   | has-system-id-FAIL.yaml |
   | has-system-id-PASS.yaml |
   | has-system-name-short-FAIL.yaml |
@@ -323,6 +321,8 @@ Examples:
   | information-type-id-PASS.yaml |
   | information-type-system-FAIL.yaml |
   | information-type-system-PASS.yaml |
+  | inter-boundary-component-direction-incoming-has-ipv-uri-FAIL.yaml |
+  | inter-boundary-component-direction-incoming-has-ipv-uri-PASS.yaml |
   | inter-boundary-component-has-direction-FAIL.yaml |
   | inter-boundary-component-has-direction-PASS.yaml |
   | interconnection-direction-FAIL.yaml |
diff --git a/src/content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml b/src/content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
index 3486741d3..ffb073ec3 100644
--- a/src/content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
+++ b/src/content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
@@ -1196,6 +1196,12 @@
          </prop>
 
          <prop name="inherited-uuid" value="22222222-0000-4000-9001-009000000001" />
+
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv4-address" class="local" value="10.1.1.3"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv6-address" class="local" value="::ffff:10.1.1.3"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv4-address" class="remote" value="10.2.2.3"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv6-address" class="remote" value="::ffff:10.2.2.3"/>
+
          <link rel="used-by" href="#11111111-2222-4000-8000-009000000000"/>
 
          <status state="operational"/>
@@ -1781,6 +1787,14 @@
          <prop ns="https://fedramp.gov/ns/oscal" name="scan-type" value="database"/>
          <prop name="baseline-configuration-name" value="Baseline Config. Name"/>
          <prop name="allows-authenticated-scan" value="yes"/>
+
+
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv4-address" class="local" value="10.1.1.4"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv6-address" class="local" value="::ffff:10.1.1.4"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv4-address" class="remote" value="10.2.2.4"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv6-address" class="remote" value="::ffff:10.2.2.4"/>   
+
+
          <link href="#11111111-2222-4000-8000-009000500006" rel="used-by" />
          <status state="operational"/>
          <responsible-role role-id="admin">
@@ -2192,6 +2206,12 @@
                <p>If 'not-applicable', attest explain why authentication is not applicable in the remarks.</p>
             </remarks>
          </prop>
+
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv4-address" class="local" value="10.1.1.5"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv6-address" class="local" value="::ffff:10.1.1.5"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv4-address" class="remote" value="10.2.2.5"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="ipv6-address" class="remote" value="::ffff:10.2.2.5"/>
+
          <link href="#11111111-2222-4000-8000-009000500005" rel="used-by" />
          <!-- is-scanned prop applies to inventory-item (not component) -->
          <!-- <prop name="is-scanned" value="yes"/> -->
diff --git a/src/validations/constraints/content/ssp-inter-boundary-component-direction-incoming-has-ipv-uri-INVALID.xml b/src/validations/constraints/content/ssp-inter-boundary-component-direction-incoming-has-ipv-uri-INVALID.xml
new file mode 100644
index 000000000..adbd9b3ef
--- /dev/null
+++ b/src/validations/constraints/content/ssp-inter-boundary-component-direction-incoming-has-ipv-uri-INVALID.xml
@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<system-security-plan xmlns="http://csrc.nist.gov/ns/oscal/1.0"
+                      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+                      xsi:schemaLocation="http://csrc.nist.gov/ns/oscal/1.0 https://github.com/usnistgov/OSCAL/releases/download/v1.1.2/oscal_ssp_schema.xsd"
+                      uuid="12345678-1234-4321-8765-123456789012">
+  
+  <system-implementation>
+
+    <component uuid="77777777-0000-4000-9000-000000000008" type="service">
+      <title>Communication Service System</title>
+      <description>
+        <p>A network communication service system.</p>
+      </description>
+      <prop name="inherited-uuid" value="11111111-0000-4000-9001-000000000001"/>
+      <prop name="implementation-point" value="external"/>
+      <prop name="direction" value="incoming" ns="https://fedramp.gov/ns/oscal"/>
+      <prop name="nature-of-agreement" ns="https://fedramp.gov/ns/oscal" value="isa"/>
+      <status state="operational"/>
+    </component>
+
+  </system-implementation>
+
+</system-security-plan>
\ No newline at end of file
diff --git a/src/validations/constraints/fedramp-external-constraints.xml b/src/validations/constraints/fedramp-external-constraints.xml
index 105ff9006..918eab463 100644
--- a/src/validations/constraints/fedramp-external-constraints.xml
+++ b/src/validations/constraints/fedramp-external-constraints.xml
@@ -527,6 +527,11 @@
                 <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
                 <message>A FedRAMP SSP system implementation section MUST have at least two inventory items.</message>
             </expect>
+            <expect id="inter-boundary-component-direction-incoming-has-ipv-uri" target="$inter-boundary-component" test="if (prop[@name='direction' and @value='incoming']) then exists(prop[@class='local' and @name=('ipv4-address','ipv6-address')]) or exists(link[@rel='uri']) else true()" level="ERROR">
+               <formal-name>Inter-Boundary Incoming Communication Direction Has an IPV Address or a URI</formal-name>
+               <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/4-ssp-template-to-oscal-mapping/#external-systems-and-services-not-having-fedramp-authorization"/>
+               <message>Component {@uuid} ({path(.)}) MUST have at least one local ipv4 address, ipv6 address, or a URI to an API.</message>
+            </expect>
             <expect id="inter-boundary-component-has-direction" target="$inter-boundary-component" test="count(prop[@name='direction']) >= 1 and count(prop[@name='direction' and @value='incoming']) &lt;= 1 and count(prop[@name='direction' and @value='outgoing']) &lt;= 1" level="ERROR">
                 <formal-name>Inter-Boundary Component Has Direction</formal-name>
                 <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/4-ssp-template-to-oscal-mapping/#external-systems-and-services-not-having-fedramp-authorization"/>
diff --git a/src/validations/constraints/unit-tests/inter-boundary-component-direction-incoming-has-ipv-uri-FAIL.yaml b/src/validations/constraints/unit-tests/inter-boundary-component-direction-incoming-has-ipv-uri-FAIL.yaml
new file mode 100644
index 000000000..f74dc0df8
--- /dev/null
+++ b/src/validations/constraints/unit-tests/inter-boundary-component-direction-incoming-has-ipv-uri-FAIL.yaml
@@ -0,0 +1,8 @@
+# Driver for the invalid inter-boundary-component-direction-incoming-has-ipv-uri constraint unit test.
+test-case:
+  name: The invalid inter-boundary-component-direction-incoming-has-ipv-uri constraint unit test.
+  description: Test that the FedRAMP SSP inter-boundary incoming communication component does not have a local ipv4 address, ipv6 address, or a URI to an API.
+  content: ../content/ssp-inter-boundary-component-direction-incoming-has-ipv-uri-INVALID.xml
+  expectations:
+  - constraint-id: inter-boundary-component-direction-incoming-has-ipv-uri
+    result: fail
\ No newline at end of file
diff --git a/src/validations/constraints/unit-tests/inter-boundary-component-direction-incoming-has-ipv-uri-PASS.yaml b/src/validations/constraints/unit-tests/inter-boundary-component-direction-incoming-has-ipv-uri-PASS.yaml
new file mode 100644
index 000000000..9c4fead39
--- /dev/null
+++ b/src/validations/constraints/unit-tests/inter-boundary-component-direction-incoming-has-ipv-uri-PASS.yaml
@@ -0,0 +1,8 @@
+# Driver for the valid inter-boundary-component-direction-incoming-has-ipv-uri constraint unit test.
+test-case:
+  name: The valid inter-boundary-component-direction-incoming-has-ipv-uri constraint unit test.
+  description: Test that the FedRAMP SSP inter-boundary incoming communication component has at least one local ipv4 address, ipv6 address, or a URI to an API.
+  content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
+  expectations:
+  - constraint-id: inter-boundary-component-direction-incoming-has-ipv-uri
+    result: pass
\ No newline at end of file