Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mlflow-skinny instead of mlflow to reduce the number of dependencies #509

Closed
wants to merge 1 commit into from
Closed

Use mlflow-skinny instead of mlflow to reduce the number of dependencies #509

wants to merge 1 commit into from

Conversation

Galileo-Galilei
Copy link
Owner

Description

Close #486

Development notes

Change requirements from mlflow to mlflow-skinny

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei
Copy link
Owner Author

Hi @rxm7706 @marrrcin, can you test if it works on your side? There are very little things breaking, but you need a recent version of mlflow-skinny so this is a regression in a because it is like dropping support for mlflow 1.X.

@Galileo-Galilei Galileo-Galilei changed the title ➖ USe mlflow-skinny instead of mlflow to reduce the number of dependencies ➖ Use mlflow-skinny instead of mlflow to reduce the number of dependencies Dec 20, 2023
@Galileo-Galilei Galileo-Galilei changed the title ➖ Use mlflow-skinny instead of mlflow to reduce the number of dependencies Use mlflow-skinny instead of mlflow to reduce the number of dependencies Dec 20, 2023
@marrrcin
Copy link

Not sure I get it 🤔 Maybe just do >1.0.0 then?

@Galileo-Galilei
Copy link
Owner Author

Closing in favor of #486 (comment)

@Galileo-Galilei Galileo-Galilei deleted the km-skinny branch August 5, 2024 12:58
@Galileo-Galilei Galileo-Galilei restored the km-skinny branch August 5, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using MLflow Skinny instead of MLflow as the required dependency.
2 participants
@Galileo-Galilei @marrrcin