Make tests for the invoke module more stringent

[gkapfham]

Current the tests in the test_invoke suite are achieving full statement coverage. However, the tests do not have stringent checks on the status of the function under test, like invoke.invoke_all_fragment_checks. These tests should actually inspect the results of the report that is populated after performing the check and make sure that it contains the expected results.

[gkapfham]

Note that issue may be less of a concern once we go to a linting interface, as described in Issue #175.

[simojo]

Think this would be a good issue for me to start on? I'm not sure if the linting interface lessened its importance, though.

[Michionlion]

I think this is definitely still something that needs to be fixed, although depending on your confidence in understanding of the system you may want to start with a simpler issue -- this one will require some knowledge of how we create a report dictionary, and what the contents of that dictionary should be for various invocations of the check functions. Note that some individual checks also may have test suites attached, and we want to try to multiplex our testing suites (have different inputs for as many situations as possible); thus, in adding to the test_invoke suite we'll want to make sure we're using different values and possibly triggering different edge cases than the individual check tests if possible.

[simojo]

Yes, good point. I wouldn't want to make any duplicates or unnecessary tests. What issue would be a good-first-issue then?

[Michionlion]

I think the best places to start, issue-wise, may be #196 or #194. I'd also recommend just browsing the code and trying to understand how things work -- if you want to join the GatorEducation slack channel that would be a good place to learn and ask questions that might not be as issue-driven. If you do that you could probably start trying to tackle this one too, with a bit of help from @gkapfham @corlettim @schultzh @alexheinle and myself.

[gkapfham]

Hi @sjones-gh, thanks for your interest in the project! Let us know if you have questions about picking an issue that you can start to work on as we are all glad to help.