Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicker dataset experimentation #9

Closed
AmitMY opened this issue Feb 14, 2025 · 0 comments
Closed

Quicker dataset experimentation #9

AmitMY opened this issue Feb 14, 2025 · 0 comments

Comments

@AmitMY
Copy link
Contributor

AmitMY commented Feb 14, 2025

To catch errors early, I recommend to swap the order of the splits here:

return [
datasets.SplitGenerator(
name=datasets.Split.TRAIN,
gen_kwargs={
"metafile_path": self.config.train_metadata_dir,
"split": f"{datasets.Split.TRAIN}"
}
),
datasets.SplitGenerator(
name=datasets.Split.VALIDATION,
gen_kwargs={
"metafile_path": self.config.validation_metadata_dir,
"split": "val"
}
),
datasets.SplitGenerator(
name=datasets.Split.TEST,
gen_kwargs={
"metafile_path": self.config.test_metadata_dir,
"split": f"{datasets.Split.TEST}"
}
),
]

validation, test, then train

Since the validation and test sets are smaller, it is in my opinion most useful to have them run first - such that if they fail, we get a signal right away.
For me, the train split takes 8~ hours, and who knows, might fail at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant