Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid click feature support #240

Open
jeffabailey opened this issue Sep 9, 2023 · 3 comments
Open

Mermaid click feature support #240

jeffabailey opened this issue Sep 9, 2023 · 3 comments
Labels
improvement Improvement to existing integration

Comments

@jeffabailey
Copy link

jeffabailey commented Sep 9, 2023

Using the Mermaid click feature with the _blank option within the Mermaid integration results in undesirable behavior.

See the following video to see steps, and this page to try it out.

Page: https://jeffs-organization-3.gitbook.io/managing-inner-source-projects/~/changes/NdT1gsJCKqwbVRhqQRZF/use_gqm

Click the Reduce Duplication graph element to reproduce the issue.

Video: https://github.com/GitbookIO/integrations/assets/776901/2d1d6d4e-4116-4384-8b11-3e08031cd875

@rrrutledge
Copy link

The Mermaid graph renders in a small iframe, and click events meant to take you to some full-page view stay rendered within that iframe. We'd rather have the click targets take you to a full-page view of the target.

@addisonschultz addisonschultz added bug Something isn't working improvement Improvement to existing integration and removed bug Something isn't working labels Sep 27, 2023
@addisonschultz
Copy link
Collaborator

Can you try and add _top to the link you're trying to open?

@jeffabailey
Copy link
Author

Hi Addison, thanks for the response.

Yes, I tried using _top along _blank and _parent as described here:

https://mermaid.js.org/syntax/flowchart.html#interaction

Here's an updated version of the page demonstrating the issue more directly.

https://jeffs-organization-3.gitbook.io/managing-inner-source-projects/introduction-1/goals/use_gqm

Underlying mermaid code.

flowchart LR
    blank-->top
    top-->parent 
    
    click blank "https://www.github.com" _blank
    click top "https://www.github.com" _top
    click parent "https://www.github.com" _parent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing integration
Projects
None yet
Development

No branches or pull requests

3 participants