Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for named markdown images #17

Closed
SamyPesse opened this issue Jul 16, 2016 · 4 comments
Closed

Support for named markdown images #17

SamyPesse opened this issue Jul 16, 2016 · 4 comments
Labels

Comments

@SamyPesse
Copy link
Member

See GitbookIO/gitbook#1447

@simov
Copy link

simov commented Jul 16, 2016

I don't know if that could be of any help, but the marked parser already supports that.

simov added a commit to simov/purest-docs that referenced this issue Jul 17, 2016
@SamyPesse
Copy link
Member Author

Fixed by #16

@simov
Copy link

simov commented Jul 28, 2016

Excuse me but named markdown images refers to [![image-url]][image-link] so the problem is that your parser does not support named image-link with image-url. I'm copy/pasting my other issue here:


Things like:

travis-ci

[![travis-ci]][travis]

  [travis-ci]: https://img.shields.io/travis/simov/purest/master.svg?style=flat-square (Build Status - Travis CI)
  [travis]: https://travis-ci.org/simov/purest

As you can see this is rendered correctly in GitHub, the image above have a title and it can be clicked. This doesn't seem to work with latest GitBook:

CLI version: 2.3.0
GitBook version: 3.2.0

The PR you are referring to adds support for titles, but not support for named image-link. So I suggest you re-open this issue.

@SamyPesse
Copy link
Member Author

Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants