Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line separator should not be "/n" (sic) #76

Closed
bazzargh opened this issue Jul 19, 2017 · 1 comment
Closed

Line separator should not be "/n" (sic) #76

bazzargh opened this issue Jul 19, 2017 · 1 comment

Comments

@bazzargh
Copy link
Contributor

bazzargh commented Jul 19, 2017 •
edited
Loading

markup-it/src/html/parse.js

Line 303 in ad90bfb

sep = sep || detectNewLine(text) || '/n';

^ found this reading the code. It's falling back on using "/n" not "\n" as the line break if detection fails, which is nonsensical. detect-newline already contains code to cover this - detectNewline.graceful(x) will return "\n" for this case.
https://github.com/sindresorhus/detect-newline/blob/master/index.js#L23
bazzargh added a commit to bazzargh/markup-it that referenced this issue Jul 19, 2017
@bazzargh
Issue GitbookIO#76 /n is not a valid line break
a1b6f16 
This is an obvious typo, but the test in this PR shows it can trigger
a bug.
SamyPesse pushed a commit that referenced this issue Jul 19, 2017
@bazzargh @SamyPesse
Issue #76 /n is not a valid line break (#77)
7fa0b8c 
This is an obvious typo, but the test in this PR shows it can trigger
a bug.
@SamyPesse
Copy link
Member

Closed by #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SamyPesse @bazzargh