Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in geoviewer.py -vmin/vmax arguments #417

Closed
adehecq opened this issue Dec 19, 2023 · 0 comments · Fixed by #418
Closed

Bug in geoviewer.py -vmin/vmax arguments #417

adehecq opened this issue Dec 19, 2023 · 0 comments · Fixed by #418
Assignees
@adehecq
Labels
bug Something isn't working

Comments

@adehecq
Copy link
Member

adehecq commented Dec 19, 2023

Describe the bug
When calling geoviewer.py with arguments -vmin or -vmax set to a percentile value, the nodata values are not taken into account. This is particularly visible if the requested percentile value falls within the nodata, because the min/max value set can be the nodata value.

To Reproduce
Run geoviewer.py on the ASTER dataset, with -vmin=1%:
geoviewer.py Exploradores_ASTER/AST_L1A_00303182012144228_Z.tif -vmin 1%
The color scale starts at -9999.

Expected behavior
Masked values should be ignored when calculating the percentile.
@adehecq adehecq added the bug Something isn't working label Dec 19, 2023
@adehecq adehecq self-assigned this Dec 19, 2023
adehecq added a commit to adehecq/GeoUtils that referenced this issue Dec 20, 2023
@adehecq
Fixes GlacioHack#412 and GlacioHack#417
67aeabf
@adehecq adehecq mentioned this issue Dec 20, 2023
Merged
@adehecq adehecq linked a pull request Dec 20, 2023 that will close this issue
Fix several issues in geoviewer #418
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adehecq adehecq

Labels
bug Something isn't working
Projects
Hack - Jan 2024 - Geoutils Version Release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix several issues in geoviewer adehecq/GeoUtils
1 participant
@adehecq