Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CROP and load_rio() #645

Open
adebardo opened this issue Jan 27, 2025 · 2 comments
Open

Refactor CROP and load_rio() #645

adebardo opened this issue Jan 27, 2025 · 2 comments

Comments

@adebardo
Copy link

Context

Currently, the handling of region of interest (ROI) or crop geometry is split between _load_rio() and the crop() method. Which is hard to maintain.
We propose to delete the ROI management from _load_rio() and use the crop() method before calling _load_rio(), if a ROI is provided during raster initialization.

@adebardo adebardo changed the title Refactor ROI handling in the Raster class Refactor CROP and load_rio() Jan 27, 2025
@adebardo
Copy link
Author

@rhugonnet @vschaffn is this okay ?

@adehecq
Copy link
Member

adehecq commented Jan 29, 2025

I fully agree we should merge the two, and the best choice is to move the ROI functionality into crop (see my comment in #642). Additionally, I would recommend sticking to one name, as keeping both ROI and crop adds confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants