Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Electricity Maps API configuration is out of date #613

Open
1 task done
jbdietrich opened this issue Feb 3, 2025 · 1 comment
Open
1 task done

[Bug]: Electricity Maps API configuration is out of date #613

jbdietrich opened this issue Feb 3, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@jbdietrich
Copy link

jbdietrich commented Feb 3, 2025

Contact Details

[email protected]

What happened?

The existing configuration documentation for Electricity Maps is a little out of date:

  1. Electricity Maps has deprecated the co2signal.com domain
  2. Electricity Maps no longer has a free trial, but instead a free tier with no expiration

Therefore, we propose updating both the code and documentation:

  1. In the code, remove the distinction in configuration between ElectricityMapsFree and ElectricityMaps since it appears to still refer to the co2signal.com domain
  2. In the documentation, remove the distinction between ElectricityMapsFree and ElectricityMaps
  3. Update the note in the documentation's "restriction" section since it is largely still valid; forecasts are still only available to paid API tokens

We can provide a PR to do this. (Note that I was unsure whether this could strictly be considered a documentation change since we'd actually update the config code).

client

CLI

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jbdietrich jbdietrich added the bug Something isn't working label Feb 3, 2025
@danuw
Copy link
Collaborator

danuw commented Feb 3, 2025

Thank you @jbdietrich for raising that and a PR would be more than welcome if possible please.

Cc @vaughanknight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants