Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster release cycle #105

Open
jarikujansuu opened this issue Nov 12, 2021 · 10 comments
Open

Faster release cycle #105

jarikujansuu opened this issue Nov 12, 2021 · 10 comments

Comments

@jarikujansuu
Copy link
Contributor

Not sure if this is correct channel for this kind of request.

But I wish there was faster release cycle, currently of course interested in having released version which would include #101. Last release has been October 7th and after that has been 2 functional improvement PRs, and that consistent read support was merged 23 days ago.

I am now using git dependency but as there are also no tags have to rely on random rev value which is not obviously clear what we are using.

@dimaqq
Copy link
Contributor

dimaqq commented Nov 12, 2021

@ojii WDYT about giving Jari pypi privileges?

@tedchou12
Copy link

Why not setup deploy flow to pypi in github actions when merging to master?

@ojii
Copy link
Contributor

ojii commented Nov 15, 2021

I'd prefer automated releases as ted suggests, but I've never set that up so I'm not sure what the current state of the art is. if someone knows, please let me know.

@tedchou12
Copy link

tedchou12 commented Nov 15, 2021

@ojii
It seems like there is no setup.py file in the repo. I can set it up.
Could you help me with the following?

  1. Put a pypi api token under the secrets of this repo.

I can do the rest.

@dimaqq
Copy link
Contributor

dimaqq commented Nov 16, 2021

We use poetry

@dimaqq
Copy link
Contributor

dimaqq commented Nov 16, 2021

Manually I'd do poetry build and then poetry publish
I can’t recall if the latter asks for credentials or need them in advance.

@tedchou12
Copy link

Just briefly reading looking at:
https://python-poetry.org/docs/repositories/

Poetry authenticates with pypi via poetry config ..., so you probably have preconfigured it before at some point?

I think this the steps in this article makes sense:
https://dev.to/iancleary/test-and-publish-a-python-package-to-pypi-using-poetry-and-github-actions-186a

In that case, to upload to pypi still needs a pypi token.
Screen Shot 2021-11-16 at 9 24 27

@ojii
Copy link
Contributor

ojii commented Nov 16, 2021

Manually I'd do poetry build and then poetry publish

huh I still use twine upload am I doing things wrong?

@ojii
Copy link
Contributor

ojii commented Nov 16, 2021

@jarikujansuu while we're trying to figure out how to automate/improve this, I've released 21.11.

@tedchou12
Copy link

Dima is right, poetry doesn't require twine upload.
But pypi credentials are still needed.

I tried it a few times with pypi-test, seems to be working fine.
#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants