Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuple input for advanced usage #27

Open
hanscg opened this issue Oct 18, 2023 · 0 comments
Open

Tuple input for advanced usage #27

hanscg opened this issue Oct 18, 2023 · 0 comments
Assignees

Comments

@hanscg
Copy link
Contributor

hanscg commented Oct 18, 2023

Perhaps eventually a new major release where we change how all the parameters
are passed could sort it out so that instead we are explicit about the tuples
of directory+tfversion+args instead of trying to match them across three
arrays.

Combining the three parameters into tuples sounds great for more complex cases, but I'm worried that the change will make this action looks too complicated for people using this with simpler cases (e.g checking just one directory with the latest version of Terraform)

Instead of replacing the current input parameters, perhaps we can introduce a new parameter for advanced usage while keeping the existing parameters? This way we don't need to introduce breaking changes either. I'm thinking about something like this (haven't really thought about the naming or whether this is valid):

uses:
   check_tuple: "[ ('path1', 'version1', 'args1'), ('path2, 'version2, 'args2')]"

Originally posted by @hanscg in #23 (comment)

@hanscg hanscg self-assigned this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant