Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call to undefined method HandlerFailedException::getNestedExceptions() #11

Open
starred-gijs opened this issue Mar 18, 2024 · 1 comment · May be fixed by #12
Open

Call to undefined method HandlerFailedException::getNestedExceptions() #11

starred-gijs opened this issue Mar 18, 2024 · 1 comment · May be fixed by #12

Comments

@starred-gijs
Copy link
Contributor

During the PR to support Symfony 7 in #10 I did miss one BC break in the ExceptionLogger https://github.com/Happyr/bref-messenger-failure-strategies/blob/0.5.0/src/ExceptionLogger.php#L36

HandlerFailedException::getNestedExceptions has been removed and replaced with HandlerFailedException::getWrappedExceptions

I actually did not use this ExceptionLogger during the upgrade, and PHPStan only runs on PHP 8.1 which will not run on Symfony 7.

Any suggestions on how you want to see this fixed? Do a version check on Kernel::MAJOR_VERSION or method_exists or do you have any other suggestions?
@starred-gijs starred-gijs changed the title Call to undefined method Symfony\\Component\\Messenger\\Exception\\HandlerFailedException::getNestedExceptions() Call to undefined method HandlerFailedException::getNestedExceptions() Mar 18, 2024
@starred-gijs starred-gijs linked a pull request Mar 21, 2024 that will close this issue
Open
@starred-gijs
Copy link
Contributor Author

I did the version check with method_exists. Please let me know what you think @Nyholm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix BC issue with ExceptionLogger starred-com/bref-messenger-failure-strategies
1 participant
@starred-gijs