-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatChar stores encoding, but it's inaccessible to the user #21
Comments
All of the The official Mat-File Format (page 15) added UTF16 and UTF32 encoding sometime a few years ago. UTF32 doesn't seem to actually be readable by MATLAB though. MatFileRW implements reading UTF16/32, but it may not offer an option to serialize it. |
Sorry, I think I may have misread the issue. Making the encoding be accessible via e.g. The |
Roger. I'll submit a PR after #22 gets merged :) |
Resolved with #26 |
MatChar
has a configurableencoding
field:https://github.com/HebiRobotics/MatFileIO/blob/6b7cc2661a20523c3cbc3918977bc50d6e1127dd/src/main/java/us/hebi/matlab/mat/format/MatChar.java#L46-L51
But it's inaccesible from the public
Char
API:https://github.com/HebiRobotics/MatFileIO/blob/6b7cc2661a20523c3cbc3918977bc50d6e1127dd/src/main/java/us/hebi/matlab/mat/types/Char.java
Do MAT-files really support multiple encodings, or can we hardcode UTF8? MatFileRw seems to only support UTF8.
https://github.com/diffplug/matfilerw/blob/2a4965c7eaf7f25c2153ec06404fa9b457c2098a/src/main/java/com/jmatio/types/MLChar.java
Adding degrees of freedom for future backward-compatibility seems tricky. Not a big deal though :)
The text was updated successfully, but these errors were encountered: