-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] "Don't show again" button on "Make sure that you are logged in" banner has no effect #2104
Comments
I am experiencing this issue as well and I am also at a loss as to what exactly is failing to load and, similarly, cannot get the banner to go away between pages or reloads. |
I've had this error before sporadically. I tried examining the console and found the two errors to be for "hn" and "LoginError", however I too was unable to find any root cause in the files to show the cause for it. I signed out of steam, deleted all cookies/local storage (for both store and community pages) and attempted to recreate the error to no avail. I also tried recreating the error in another session/browser with signing in into store only, community only and both concurrently however that didn't seem to recreate the bug either even after several days of trying. you can try resetting the cookies/storage and see if that fixes the issue, and in the meanwhile if anyone was able to find steps to reproduce this bug reliably, I would be interested in knowing to track this down further. |
Idk how much help is that but for me one of the features failed was "hn" which is supposedly related to the coupons. |
Quoting myself: "Don't show again" not working was an issue before but it was quite some time ago and the extension has changed a lot since then. I'll have to check what's going on 😅 |
Thanks a lot for all the info because I'm finally seeing the error again. It seems that two things are happening here. 1) The handleClose function in LoginWarning.svelte is writing to localstorage to hide the login warning however I don't see any changes in local storage after hitting the hide button. 2) I don't see anywhere in AugmentedSteamWarnings or any other file the use of this data in local storage (hide_login_warn_store or hide_login_warn_community) to not dispatch the warning again if set to true. |
I encountered something similar, but disabling my ad-block for the Steam.com domain resolved the issue. I would see errors in my browser console about failing to connect to community but when I clicked the community tab I was logged in. After disabling uBlock Origin the errors stopped appearing, even after a reboot. |
Expected Behavior
Dismissing this banner via Don't show again should be remembered, and it shouldn't show again.
Actual Behavior
The banner reappears on every page.
Context
I'm constantly seeing the "Make sure that you are logged into steamcommunity.com" banner prompt within
steamcommunity.com
itself (not the store):I use Firefox with strong privacy features enabled, which I understand can cause interaction issues between Steam's domain (#818). I've yet to figure out exactly what isn't working though -- the (!) icon claims two failed requests, but the console doesn't offer much context and there are no failed HTTP requests that I can see:
However, I've yet to see any obvious signs of breakage (presumably just one or more features not loading at all) so this hasn't really been an issue. The banner is a minor nuisance though, as I can't seem to dismiss it in any permanent way.
Steps to Reproduce the Problem
steamcommunity.com
with a configuration that causes the bannerSpecifications
The text was updated successfully, but these errors were encountered: