Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on bad input when creating model "From name" #494

Closed
azomDev opened this issue Jan 22, 2025 · 3 comments
Closed

Crash on bad input when creating model "From name" #494

azomDev opened this issue Jan 22, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@azomDev
Copy link

azomDev commented Jan 22, 2025

Describe the bug
Here is the crash I mentioned in #488:
When a bad input is given to the "From name", it crashes (if it did not yet crash, try to click on "Manage Models" button in the top center)

An example of a bad input is:

deepseek-r1:1.5b

Note that the string includes the newline, which is what makes it crash. (I was copying online and copied the newline accidentally).

Expected behavior
The program to not crash

Screenshots
If applicable, add screenshots to help explain your problem.

Debugging information
I didn't test it today, but very probably the same as #488 since I crashed it to show the other issue.

Extra
I was looking through the code to try to help fix this, but I honestly can't find where is the function to process the user input there. If I have where it is I can help fix it if you want.

Edit: I think I found it? model_creator_accept function in window.py

@azomDev azomDev added the bug Something isn't working label Jan 22, 2025
@Jeffser
Copy link
Owner

Jeffser commented Jan 22, 2025

Hi, I rewrote all the model manager stuff, you can see the progress here.

The only thing that's left is the option to add models by name so that's that, once I implement it I'll make sure to correctly handle model names.

The code you found is unrelated, but it's somewhat similar to how it's handled in the current release build, so you weren't too far off.

@azomDev
Copy link
Author

azomDev commented Jan 22, 2025

Fair enough, I did not notice that, thanks! In that case I'll wait to open issues if I found some bugs until the updates rolls out.

@Jeffser
Copy link
Owner

Jeffser commented Jan 23, 2025

Hi I added back the option to pull models by name and it removes any newlines

4eaa12b

@Jeffser Jeffser closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants