Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Activity - QA] Search function not working for action type or token in Activity feed #3701

Closed
olgapod opened this issue Nov 12, 2024 · 3 comments · Fixed by #4062
Closed
Assignees
Labels
bug Something isn't working Priority: P2 (Medium)

Comments

@olgapod
Copy link
Contributor

olgapod commented Nov 12, 2024

Steps to reproduce

  1. Navigate to the Activity Feed.
  2. Open the search filter and enter a value that matches an "Action type" (e.g., "Unlock Tokens") or a "Token" name.
  3. Observe whether the search returns the correct results for the entered field.

Expected behaviour

  • The search should accurately filter results based on the "Action type" and "Token" fields, displaying all matching activities.

Actual behaviour

  • Searching by "Action type" or "Token" does not yield the correct results, making it difficult for users to locate specific activities.

https://www.notion.so/colony/Activity-Feed-c4c47253f8e8414fba93d9bd1c09f879

image image
@olgapod olgapod added the bug Something isn't working label Nov 12, 2024
@rumzledz
Copy link
Contributor

I am able to search by token:

Image

I think you're not able to search for "Unlock tokens" because there is action called "Unlock tokens". Our action is called "Unlock token" which we have a dedicated filter for:

Image

But I guess if the intention is to make the "unlock token" action searchable thing too then yep, can do 👌

@olgapod
Copy link
Contributor Author

olgapod commented Jan 8, 2025

@rumzledz Could you try on my colony to find all added tokens https://arbitrum-sepolia.colony.io/invite/345/3de70ac0-bff1-4fc9-9c72-10081917bd50
image

image

@iamsamgibbs
Copy link
Contributor

I spent a little bit of time looking into this today.

Searching by token does eventually work on your colony, but it took over 3 minutes to search through all the actions. I don't think the search works very well with so many actions in the same colony...

Screenshot 2025-01-09 at 15 41 20

Screenshot 2025-01-09 at 15 41 45

It does appear that searching by action type doesn't work properly though, it checks for the ColonyActionType rather than how the name appears in the UI, so Unlock token requires searching for UNLOCK_TOKEN.

Screenshot 2025-01-09 at 16 05 50

I'll assigned myself this issue and fix up the action type, if we want to optimise the search speed that will be a bigger job that we should address separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: P2 (Medium)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants