DSP.jl still exports fftfreq

[KronosTheLate]

Despite this note

it seems like this package still exports fftfreq, causing a colision when using both DSP.jl and FFTW.jl:

julia> using Pkg; pkg"update DSP"; using DSP
   Updating registry at `C:\Users\densb\.julia\registries\General`
   Updating git-repo `https://github.com/JuliaRegistries/General.git`

  A bunch of un-interesting changes

[ Info: Precompiling DSP [717857b8-e6f2-59f4-9121-6e50c889abd2]

(@v1.5) pkg> status DSP
Status `C:\Users\densb\.julia\environments\v1.5\Project.toml`
  [717857b8] DSP v0.6.10

julia> using DSP, FFTW

julia> fftfreq(1:10, 1)
WARNING: both FFTW and DSP export "fftfreq"; uses of it in module Main must be qualified
ERROR: UndefVarError: fftfreq not defined
Stacktrace:
 [1] top-level scope at REPL[4]:1

[KronosTheLate]

I tried to look for where it gets exported, and the only credible culprit seems to be https://github.com/KronosTheLate/DSP.jl/blob/stop_export_of_fftfreq/src/periodograms.jl. Even though this module does not explicitly export fftfreq, is it possible that it is exported due to it being included?

[galenlynch]

These functions were moved to AbstractFFTs and deprecated in DSP.jl in version 0.6.1. The export is occurring here on the "v0.6.9" branch while we prepare the breaking v0.7 release:

DSP.jl/src/deprecated.jl

Lines 8 to 9 in b97fc0d

	Base.@deprecate fftfreq(n::Int, fs::Real=1) FFTW.fftfreq(n, fs)
	Base.@deprecate rfftfreq(n::Int, fs::Real=1) FFTW.rfftfreq(n, fs)

We'll remove these deprecations with the upcoming breaking release, at which point I'll close this issue.

[wheeheee]

Closed with #383