-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the minimum required Julia version to 1.6 #532
Conversation
Might want to add stdlibs to compat at the same time, to get JuliaRegistrator to automerge into the general registry when you wish to release. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 18 18
Lines 3078 3078
=======================================
Hits 3001 3001
Misses 77 77 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove some of the old versions in FFTW, OffsetArrays, Polynomials, Reexport, and SpecialFunctions?
I just pushed a commit to see if pushing aggressively will work with 1.6.
We may want to do this after #458 merges so that we can adopt these new deps from 0.8-dev. |
@martinholters Note I bumped DSP.jl version to 0.8.0 here which will go on master. Hence the next version tag will be 0.8.0 and we can pull in a few breaking changes as discussed in the Analog Filter PR. |
I guess so. I doubt we have any dependents still requiring them - and if so, that would be a good opportunity to incentivize to update. Also, we don't test whether we're actually still compatible with the old versions of out dependencies, so might be making false promises here. Bottom line: Yes, lets drop the old versions from out compat.
Hm? I mean yes, combing this compat bump with the version bump to 0.8 sounds reasonable (though not strictly necessary by semver, I believe), but why should that wait for #458? |
Agree we do not need to wait for the other PR to merge for the version bump. This seems like it is good to merge now. |
Merging this for now. We can always tweak as we go along. |
Ref. #524 (review)
I don't think we have to worry anymore about versions older than 1.6 (current LTS released almost three years ago).