Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std to test lpc error #542

Merged
merged 1 commit into from
Feb 22, 2024
Merged

use std to test lpc error #542

merged 1 commit into from
Feb 22, 2024

Conversation

wheeheee
Copy link
Member

The lpc error was previously compared to 1, but the std of the randn generated signal is a better choice.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (4213e9a) to head (dad73ce).
Report is 72 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          18       18           
  Lines        3125     3125           
=======================================
  Hits         3049     3049           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Of course, std(s) will be quite close to one, but why risk spurious test failures.

@wheeheee wheeheee merged commit b1f1604 into JuliaDSP:master Feb 22, 2024
11 checks passed
@wheeheee wheeheee deleted the err_std branch February 22, 2024 00:33
@wheeheee wheeheee added the no changelog Prevent TagBot from inclusion in release notes label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Prevent TagBot from inclusion in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants