Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed test should fixed be re-enabled on windows #227

Open
LilithHafner opened this issue Jun 5, 2023 · 3 comments
Open

Failed test should fixed be re-enabled on windows #227

LilithHafner opened this issue Jun 5, 2023 · 3 comments
Labels
bug Something isn't working continuous integration (ci)

Comments

@LilithHafner
Copy link
Member

CI failed on commit f09e46d163, likely due to a flakey Downloads test

https://buildkite.com/julialang/julia-master/builds/24485#01887c4b-a593-4a4a-96f0-807845a73fa8/12484-12927

Error During Test at C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\test\runtests.jl:381
  Got exception outside of a @test
  TaskFailedException
  Stacktrace:
    [1] try_yieldto(undo::typeof(Base.ensure_rescheduled))
      @ Base .\task.jl:921
    [2] wait()
      @ Base .\task.jl:985
    [3] wait(c::Base.GenericCondition{ReentrantLock}; first::Bool)
      @ Base .\condition.jl:130
    [4] wait(c::Base.GenericCondition{ReentrantLock})
      @ Base .\condition.jl:125 [inlined]
    [5] take_buffered(c::Channel{Any})
      @ Base .\channels.jl:458
    [6] take!(c::Channel{Any})
      @ Base .\channels.jl:452 [inlined]
    [7] sync_end(c::Channel{Any})
      @ Base.Experimental .\experimental.jl:64
    [8] macro expansion
      @ .\experimental.jl:102 [inlined]
    [9] macro expansion
      @ .\timing.jl:395 [inlined]
   [10] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\test\runtests.jl:392 [inlined]
   [11] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Test\src\Test.jl:1547 [inlined]
   [12] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\test\runtests.jl:382 [inlined]
   [13] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Test\src\Test.jl:1547 [inlined]
   [14] top-level scope
      @ C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\test\runtests.jl:4
   [15] include(mod::Module, _path::String)
      @ Base .\Base.jl:489 [inlined]
   [16] macro expansion
      @ Main C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\test\testdefs.jl:29 [inlined]
   [17] macro expansion
      @ Main C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Test\src\Test.jl:1547 [inlined]
   [18] macro expansion
      @ Main C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\test\testdefs.jl:23 [inlined]
   [19] macro expansion
      @ Main .\timing.jl:503 [inlined]
   [20] runtests(name::String, path::String, isolate::Bool; seed::UInt128)
      @ Main C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\test\testdefs.jl:21
   [21] invokelatest(::Any, ::Any, ::Vararg{Any}; kwargs::@Kwargs{seed::UInt128})
      @ Base .\essentials.jl:866
   [22] (::Distributed.var"#110#112"{Distributed.CallMsg{:call_fetch}})()
      @ Distributed C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Distributed\src\process_messages.jl:285
   [23] run_work_thunk(thunk::Distributed.var"#110#112"{Distributed.CallMsg{:call_fetch}}, print_error::Bool)
      @ Distributed C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Distributed\src\process_messages.jl:70
   [24] (::Distributed.var"#109#111"{Distributed.CallMsg{:call_fetch}, Distributed.MsgHeader, Sockets.TCPSocket})()
      @ Distributed C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Distributed\src\process_messages.jl:285
      nested task error: RequestError: Failed to connect to httpbingo.julialang.org port 443 after 21054 ms: Couldn't connect to server while requesting https://httpbingo.julialang.org/delay/2?id=75
      Stacktrace:
        [1] (::Downloads.var"#9#18"{IOBuffer, Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Bool, String, Bool, Bool})(easy::Downloads.Curl.Easy)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:397
        [2] with_handle(f::Downloads.var"#9#18"{IOBuffer, Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Bool, String, Bool, Bool}, handle::Downloads.Curl.Easy)
          @ Downloads.Curl C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\src\Curl\Curl.jl:94
        [3] (::Downloads.var"#8#17")(output::Any)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:338 [inlined]
        [4] arg_write(f::Downloads.var"#8#17"{Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Bool, String, Bool, Bool}, arg::IOBuffer)
          @ ArgTools C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\ArgTools\src\ArgTools.jl:134
        [5] (::Downloads.var"#7#16")(input::Any)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:337 [inlined]
        [6] arg_read
          @ ArgTools C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\ArgTools\src\ArgTools.jl:76 [inlined]
        [7] request(url::String; input::Nothing, output::IOBuffer, method::Nothing, headers::Vector{Pair{String, String}}, timeout::Float64, progress::Nothing, verbose::Bool, debug::Nothing, throw::Bool, downloader::Nothing)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:336
        [8] kwcall(::NamedTuple, ::typeof(Downloads.request), url::AbstractString)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:304 [inlined]
        [9] (::Downloads.var"#3#4")(output::Any)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:242 [inlined]
       [10] arg_write(f::Downloads.var"#3#4"{Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Nothing, String}, arg::IOBuffer)
          @ ArgTools C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\ArgTools\src\ArgTools.jl:134
       [11] download(url::String, output::IOBuffer; method::Nothing, headers::Vector{Pair{String, String}}, timeout::Float64, progress::Nothing, verbose::Bool, debug::Nothing, downloader::Nothing)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:241 [inlined]
       [12] (::Main.Test84Main_Downloads.var"#2#3"{@Kwargs{downloader::Nothing}, String})(output::IOBuffer)
          @ Main.Test84Main_Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\test\setup.jl:13
       [13] sprint(::Function; context::Nothing, sizehint::Int32)
          @ Base .\strings\io.jl:114
       [14] sprint
          @ Main.Test84Main_Downloads .\strings\io.jl:107 [inlined]
       [15] download_body(url::String; kwargs::@Kwargs{downloader::Nothing})
          @ Main.Test84Main_Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\test\setup.jl:12 [inlined]
       [16] download_json(url::String; kwargs::@Kwargs{downloader::Nothing})
          @ Main.Test84Main_Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\test\setup.jl:18 [inlined]
       [17] (::Main.Test84Main_Downloads.var"#25#52"{Nothing, String, Int32})()
          @ Main.Test84Main_Downloads C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-f09e46d163\share\julia\stdlib\v1.10\Downloads\test\runtests.jl:394
@LilithHafner LilithHafner changed the title Test failure in CI TaskFailedException causes CI failure Jun 5, 2023
@LilithHafner
Copy link
Member Author

Another failure, this time on commit be2c35a8d2

https://buildkite.com/julialang/julia-master/builds/24483#01887c4a-460b-42cc-aec8-f35dd5db4906

The global RNG seed was 0xc6e0a561981f699bca1d6a8fd78c9a05.
Error in testset Downloads:
Error During Test at C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\test\runtests.jl:381
  Got exception outside of a @test
  TaskFailedException
  Stacktrace:
    [1] try_yieldto(undo::typeof(Base.ensure_rescheduled))
      @ Base .\task.jl:921
    [2] wait()
      @ Base .\task.jl:985
    [3] wait(c::Base.GenericCondition{ReentrantLock}; first::Bool)
      @ Base .\condition.jl:130
    [4] wait(c::Base.GenericCondition{ReentrantLock})
      @ Base .\condition.jl:125 [inlined]
    [5] take_buffered(c::Channel{Any})
      @ Base .\channels.jl:458
    [6] take!(c::Channel{Any})
      @ Base .\channels.jl:452 [inlined]
    [7] sync_end(c::Channel{Any})
      @ Base.Experimental .\experimental.jl:64
    [8] macro expansion
      @ .\experimental.jl:102 [inlined]
    [9] macro expansion
      @ .\timing.jl:395 [inlined]
   [10] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\test\runtests.jl:392 [inlined]
   [11] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Test\src\Test.jl:1547 [inlined]
   [12] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\test\runtests.jl:382 [inlined]
   [13] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Test\src\Test.jl:1547 [inlined]
   [14] top-level scope
      @ C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\test\runtests.jl:4
   [15] include(mod::Module, _path::String)
      @ Base .\Base.jl:489 [inlined]
   [16] macro expansion
      @ Main C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\test\testdefs.jl:29 [inlined]
   [17] macro expansion
      @ Main C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Test\src\Test.jl:1547 [inlined]
   [18] macro expansion
      @ Main C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\test\testdefs.jl:23 [inlined]
   [19] macro expansion
      @ Main .\timing.jl:503 [inlined]
   [20] runtests(name::String, path::String, isolate::Bool; seed::UInt128)
      @ Main C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\test\testdefs.jl:21
   [21] invokelatest(::Any, ::Any, ::Vararg{Any}; kwargs::@Kwargs{seed::UInt128})
      @ Base .\essentials.jl:866
   [22] (::Distributed.var"#110#112"{Distributed.CallMsg{:call_fetch}})()
      @ Distributed C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Distributed\src\process_messages.jl:285
   [23] run_work_thunk(thunk::Distributed.var"#110#112"{Distributed.CallMsg{:call_fetch}}, print_error::Bool)
      @ Distributed C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Distributed\src\process_messages.jl:70
   [24] (::Distributed.var"#109#111"{Distributed.CallMsg{:call_fetch}, Distributed.MsgHeader, Sockets.TCPSocket})()
      @ Distributed C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Distributed\src\process_messages.jl:285
      nested task error: RequestError: Failed to connect to httpbingo.julialang.org port 443 after 21345 ms: Couldn't connect to server while requesting https://httpbingo.julialang.org/delay/2?id=22
      Stacktrace:
        [1] (::Downloads.var"#9#18"{IOBuffer, Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Bool, String, Bool, Bool})(easy::Downloads.Curl.Easy)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:397
        [2] with_handle(f::Downloads.var"#9#18"{IOBuffer, Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Bool, String, Bool, Bool}, handle::Downloads.Curl.Easy)
          @ Downloads.Curl C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\src\Curl\Curl.jl:94
        [3] (::Downloads.var"#8#17")(output::Any)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:338 [inlined]
        [4] arg_write(f::Downloads.var"#8#17"{Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Bool, String, Bool, Bool}, arg::IOBuffer)
          @ ArgTools C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\ArgTools\src\ArgTools.jl:134
        [5] (::Downloads.var"#7#16")(input::Any)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:337 [inlined]
        [6] arg_read
          @ ArgTools C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\ArgTools\src\ArgTools.jl:76 [inlined]
        [7] request(url::String; input::Nothing, output::IOBuffer, method::Nothing, headers::Vector{Pair{String, String}}, timeout::Float64, progress::Nothing, verbose::Bool, debug::Nothing, throw::Bool, downloader::Nothing)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:336
        [8] kwcall(::NamedTuple, ::typeof(Downloads.request), url::AbstractString)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:304 [inlined]
        [9] (::Downloads.var"#3#4")(output::Any)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:242 [inlined]
       [10] arg_write(f::Downloads.var"#3#4"{Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Nothing, String}, arg::IOBuffer)
          @ ArgTools C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\ArgTools\src\ArgTools.jl:134
       [11] download(url::String, output::IOBuffer; method::Nothing, headers::Vector{Pair{String, String}}, timeout::Float64, progress::Nothing, verbose::Bool, debug::Nothing, downloader::Nothing)
          @ Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\src\Downloads.jl:241 [inlined]
       [12] (::Main.Test17Main_Downloads.var"#2#3"{@Kwargs{downloader::Nothing}, String})(output::IOBuffer)
          @ Main.Test17Main_Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\test\setup.jl:13
       [13] sprint(::Function; context::Nothing, sizehint::Int64)
          @ Base .\strings\io.jl:114
       [14] sprint
          @ Main.Test17Main_Downloads .\strings\io.jl:107 [inlined]
       [15] download_body(url::String; kwargs::@Kwargs{downloader::Nothing})
          @ Main.Test17Main_Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\test\setup.jl:12 [inlined]
       [16] download_json(url::String; kwargs::@Kwargs{downloader::Nothing})
          @ Main.Test17Main_Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\test\setup.jl:18 [inlined]
       [17] (::Main.Test17Main_Downloads.var"#25#52"{Nothing, String, Int64})()
          @ Main.Test17Main_Downloads C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-be2c35a8d2\share\julia\stdlib\v1.10\Downloads\test\runtests.jl:394

@LilithHafner
Copy link
Member Author

LilithHafner commented Jun 5, 2023 •
edited
Loading

Another failure on windows (all four failures were on windows) commit 318f0ead95

https://buildkite.com/julialang/julia-master/builds/24392#01886e42-1211-488a-9f00-662abb7f7a04/12455-13317

Another: https://buildkite.com/julialang/julia-master/builds/24541#01888cd0-d7f8-4e2a-91b4-8c47c2019445/12498-13342

@LilithHafner LilithHafner mentioned this issue Jun 5, 2023
Merged
@LilithHafner LilithHafner added the bug Something isn't working label Jun 5, 2023
@LilithHafner LilithHafner changed the title TaskFailedException causes CI failure Failed test should fixed be re-enabled on windows Aug 30, 2023
@LilithHafner
Copy link
Member Author

#228 skips this test, so it should no longer cause CI to fail on Julia master. However, I assume that whatever underlying bug caused this is still present. Hence changing the title of this issue, but not closing it or removing the bug label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working continuous integration (ci)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LilithHafner