Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a different kathara.conf file #340

Open
tcaiazzi opened this issue Feb 14, 2025 · 2 comments
Open

Allow specifying a different kathara.conf file #340

tcaiazzi opened this issue Feb 14, 2025 · 2 comments
Assignees
Milestone

Comments

@tcaiazzi
Copy link
Member

tcaiazzi commented Feb 14, 2025

Discussed in KatharaFramework Discussions #339

Summary

As @chlohr pointed out in the linked discussion, it would be beneficial to allow users to specify a different kathara.conf file when executing a command. Currently, Kathara looks at ~/.config/kathara.conf, but in some cases, users may need to override this with a custom configuration.

Proposed Solution

  • Add an option to specify a custom kathara.conf file to all commands.
  • Ensure backward compatibility by defaulting to ~/.config/kathara.conf when no alternative file is provided.
  • Update the documentation to reflect this new option.
@tcaiazzi tcaiazzi changed the title Selecting another kathara.conf Allow specifying a different kathara.conf file when starting a network scenario Feb 14, 2025
@tcaiazzi tcaiazzi changed the title Allow specifying a different kathara.conf file when starting a network scenario Allow specifying a different kathara.conf file Feb 14, 2025
@tcaiazzi tcaiazzi added this to the Release 3.7.9 milestone Feb 14, 2025
@Skazza94
Copy link
Member

@tcaiazzi I would suggest a variation of this feature. Instead of adding an extra parameter to each command, another solution is to check if the network scenario folder has a kathara.conf file inside. If so, all the commands use that configuration file when running in a specific folder. We should also add an INFO logging to the user (if another configuration file is used).

@tcaiazzi
Copy link
Member Author

@Skazza94 I agree with you, your solution offers the same flexibility without requiring changing all commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants