MSL: Expose information about specialization constants - macro mapping #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dboyan
force-pushed
the
msl-specialize-macro
branch
2 times, most recently
from
0f28449 to
572cba9
Compare
|
I have updated the PR to finalize the API and clean up unnecessary code in previous versions. It does not change the generated MSL code but rather provides some extra information for users to know the handling of specialization constants in MSL to properly implement specialization. The user of the API is: KhronosGroup/MoltenVK#2441 (The API is stable and most likely won't change regardless of the user implementation) Please let me know if there is concern over the change or amendment needed. |
dboyan
force-pushed
the
msl-specialize-macro
branch
from
572cba9 to
bfb24b2
Compare
Specialization constant may be translated into either function constant or macro in MSL. MoltenVK requires different processing for the two cases. We expose the list of constant ids and their corresponding macro names so that MoltenVK can use them properly support specialization on those macros.
dboyan
force-pushed
the
msl-specialize-macro
branch
from
bfb24b2 to
2315b7c
Compare
HansKristian-Work
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specialization constant may be translated into either function constant or macro in MSL. MoltenVK requires different processing for the two cases. We expose the list of constant ids and their corresponding macro names so that MoltenVK can use them properly support specialization on those macros.
References:
KhronosGroup/MoltenVK#2434
KhronosGroup/MoltenVK#2423 (comment)