Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links in KCL stdlib documentation in CodeMirror completion should open in a new window #5165

Open
jtran opened this issue Jan 28, 2025 · 0 comments
Open

Links in KCL stdlib documentation in CodeMirror completion should open in a new window #5165

jtran opened this issue Jan 28, 2025 · 0 comments
Labels
bug Something isn't working codemirror Bugs related to code mirror. documentation Improvements or additions to documentation

Comments

@jtran
Copy link
Collaborator

jtran commented Jan 28, 2025 •
edited
Loading

Screenshare.-.2025-01-28.10_47_27.AM.mp4

When you click a link in the desktop app, it makes the app go blank.

We can't use links in stdlib function docs until we fix this.

v0.37.0

See requestCompletion() in packages/codemirror-lsp-client/src/plugin/lsp.ts for where these are generated.

modeling-app/packages/codemirror-lsp-client/src/plugin/lsp.ts

Line 396 in 648b37c

deprecatedHtml + formatMarkdownContents(documentation)

@jtran jtran added bug Something isn't working codemirror Bugs related to code mirror. documentation Improvements or additions to documentation labels Jan 28, 2025
@jtran jtran mentioned this issue Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working codemirror Bugs related to code mirror. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtran