Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL code is unnecessarily included #19

Open
RubenVerborgh opened this issue Nov 6, 2019 · 5 comments
Open

GraphQL code is unnecessarily included #19

RubenVerborgh opened this issue Nov 6, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@RubenVerborgh
Copy link
Member

Inspecting the generated package with webpack-bundle-analyzer, I noticed that GraphQL code was also included because that is required by @comunica/actor-init-sparql/engine-default.js. Would should probably have a learner config than that default.

@rubensworks
Copy link
Collaborator

This probably won't be a quick-fix. We'll have to refactor stuff a bit for this (see comunica/comunica#267)

@RubenVerborgh
Copy link
Member Author

This probably won't be a quick-fix.

We can webpack them out for now.

Also the crypto stuff is very heavy; we can likely do with https://github.com/LinkedDataFragments/Client.js/blob/master/lib/browser/crypto.js

@rubensworks
Copy link
Collaborator

Also the crypto stuff is very heavy

This is extensively being used by sparqlee. Since LDflex does not really makes use of filters at the moment, we could probably remove these from the configs as well. And then a more lightweight crypto implementation would be perfect indeed.

@RubenVerborgh
Copy link
Member Author

This is extensively being used by sparqlee.

Also for hashing though.

@rubensworks
Copy link
Collaborator

Also for hashing though.

Indeed. Only the distinct/reduced actors do hashing I think. But AFAIK LDflex doesn't use these either, so we can probably remove these from the config as well.

@joachimvh joachimvh removed their assignment Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants