-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL code is unnecessarily included #19
Comments
This probably won't be a quick-fix. We'll have to refactor stuff a bit for this (see comunica/comunica#267) |
We can webpack them out for now. Also the crypto stuff is very heavy; we can likely do with https://github.com/LinkedDataFragments/Client.js/blob/master/lib/browser/crypto.js |
This is extensively being used by sparqlee. Since LDflex does not really makes use of filters at the moment, we could probably remove these from the configs as well. And then a more lightweight crypto implementation would be perfect indeed. |
Also for hashing though. |
Indeed. Only the distinct/reduced actors do hashing I think. But AFAIK LDflex doesn't use these either, so we can probably remove these from the config as well. |
Inspecting the generated package with
webpack-bundle-analyzer
, I noticed that GraphQL code was also included because that is required by@comunica/actor-init-sparql/engine-default.js
. Would should probably have a learner config than that default.The text was updated successfully, but these errors were encountered: