Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New crash on discord.com #3395

Open
Gingeh opened this issue Jan 29, 2025 · 3 comments
Open

New crash on discord.com #3395

Gingeh opened this issue Jan 29, 2025 · 3 comments

Comments

@Gingeh
Copy link
Contributor

Gingeh commented Jan 29, 2025

Bisected to 336684b (from #3276)
Non-minimal reproduction: https://discord.com/

Remind me to try minimising the crash tomorrow.

@teaalltr
Copy link

teaalltr commented Feb 8, 2025

Bisected to 336684b (from #3276) Non-minimal reproduction: https://discord.com/ (or https://bitwarden.com/)

Remind me to try minimising the crash tomorrow.

Just a reminder to minimize the crash 😉

@Gingeh
Copy link
Contributor Author

Gingeh commented Feb 9, 2025

Thanks for the reminder, I totally forgot!

Here's the reduction:

<svg>inline text before <g style="display: block"></g></svg>

@Gingeh
Copy link
Contributor Author

Gingeh commented Feb 9, 2025

This crash is happening because svg boxes are inserted with m_ancestor_stack.last()->append_child(*layout_node) instead of insert_node_into_inline_or_block_ancestor(*layout_node, display, AppendOrPrepend::Append), this causes them to skip the calls to set_children_are_inline in the latter function.
The crash can be prevented by duplicating that logic for the svg box case but that's not ideal, @gmta what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@teaalltr @Gingeh and others