Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name Changer Plugin #8

Open
jfredett opened this issue Jul 22, 2012 · 7 comments
Open

Name Changer Plugin #8

jfredett opened this issue Jul 22, 2012 · 7 comments
Labels

Comments

@jfredett
Copy link
Contributor

When an approved user sends

!change-name <name>

percy should change his name to that name

@colwem
Copy link
Contributor

colwem commented Jul 24, 2012

Ok starting work

@colwem
Copy link
Contributor

colwem commented Jul 24, 2012

done

@jfredett
Copy link
Contributor Author

pull request?

@colwem
Copy link
Contributor

colwem commented Jul 24, 2012

I can't make a pull request from colwem/master to lpmc/master because I still have one open. I did have this in a branch but I merged it with my master. Should I cancel the original pull request?

@jfredett
Copy link
Contributor Author

Hmm. if you have it in a branch, unless you deleted the branch you should still be able to make a PR off of it. Hopefully tonight I'll be able to sync up with you and figure out this git stuff, we can put it off till then.

@colwem
Copy link
Contributor

colwem commented Jul 24, 2012

unless you deleted the branch you should still be able to make a PR off of it.

Yup I deleted it :-)

The branches were confusing so after I was finished with it I merged and deleted all my branchs back to master. I even did git push origin :channel_changer to delete it on the repo.

@jfredett
Copy link
Contributor Author

Not an issue, you can still recover it! just don't run garbage collection (which is hard to do anyway. :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants