Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies from SDK and project restructuring #29

Open
fpereira1 opened this issue Sep 25, 2024 · 0 comments
Open

Remove unused dependencies from SDK and project restructuring #29

fpereira1 opened this issue Sep 25, 2024 · 0 comments

Comments

@fpereira1
Copy link

fpereira1 commented Sep 25, 2024

Hi,

The express package, included in this project's package.json, has recently been identified with vulnerabilities (See SNYK-JS-EXPRESS-7926867).

This SDK exposes express, ejs and uuid as dependency even though they are not used in the SDK code. These dependencies are used in the docs/quickstart folder.

It would be ideal to split this repo into 2 packages/projects, one for the SDK with very minimal dependencies and another with the quick start. Quick start could even be a different repo (easier option) or this project could adopt npm workspaces

Including unnecessary dependencies like the ones mentioned express, ejs, and uuid cause the Learnosity SDK module to be flagged as vulnerable by security scanning tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant