Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hierarchy: orphaned trees #14

Open
ragunathjawahar opened this issue Jul 27, 2023 · 0 comments
Open

hierarchy: orphaned trees #14

ragunathjawahar opened this issue Jul 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ragunathjawahar
Copy link
Member

ragunathjawahar commented Jul 27, 2023

One of the assumptions I had while building the hierarchy subcommand feature was that all inheritance hierarchies within an artifact could be traced back to java.lang.Object as the root object. If this assumption were true, then we could construct a single tree that maps all classes packaged into the artifact.

However, this is not right. All artifacts are not self-contained. There could be platform/SDK classes for which we have the references but are not contained in the artifact. For example, android.app.DialogFragment is one. The bundled APK may contain a reference to this class, but eureka cannot access the class file. In this case, it is not possible to traverse its ancestral origin. The same applies to classes referenced from the Java runtime.

Due to this limitation, we end up in situations where users are presented with incomplete and misleading information. We have to mitigate or acknowledge this problem to the users.

Here are some potential first steps,

  1. Print debugging information during development to see the number of classes to which we don't have access.
  2. Instead of returning a single tree, return all orphaned trees as the parse result and print these roots before starting the server.
@ragunathjawahar ragunathjawahar added the bug Something isn't working label Jul 27, 2023
@ragunathjawahar ragunathjawahar changed the title Orphaned trees in hierarchy command hierarchy: Orphaned trees Jul 27, 2023
@ragunathjawahar ragunathjawahar changed the title hierarchy: Orphaned trees hierarchy: orphaned trees Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant