Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

where is 1.0 assign to p.normal_z? #54

Open
silent-zhou opened this issue May 25, 2023 · 0 comments
Open

where is 1.0 assign to p.normal_z? #54

silent-zhou opened this issue May 25, 2023 · 0 comments

Comments

@silent-zhou
Copy link

Is "nomal_z = 1.0" is missing in the line 935 of LidarFeatureExtractor.cpp.
because the selection of laserConerFeature is according to “if(std::fabs(p.normal_z - 1.0) < 1e-5)” in the "LidarFeatureExtractor::FeatureExtract_hap" fuction

i think the end part of “LidarFeatureExtractor::detectFeaturePoint2” should change to

if(a2d > thre2d || (a3d < thre3d2 && a1d < thre1d)) {
  for(int k = 1; k < interval; k++) {
    cloud->points[i-k].normal_z = 2.0;
    pointsLessFlat->points.push_back(cloud->points[i-k]);
    cloud->points[i+k].normal_z = 2.0;
    pointsLessFlat->points.push_back(cloud->points[i+k]);
  }
  cloud->points[i].normal_z = 2.0;
  pointsLessFlat->points.push_back(cloud->points[i]);
} else if(a3d > thre3d) {
  for(int k = 1; k < interval; k++) {
    cloud->points[i-k].normal_z = 3.0;
    pointsNonFeature->points.push_back(cloud->points[i-k]);
    cloud->points[i+k].normal_z = 3.0;
    pointsNonFeature->points.push_back(cloud->points[i+k]);
  }
  cloud->points[i].normal_z = 3.0;
  pointsNonFeature->points.push_back(cloud->points[i]);
}
else 
{
  cfor(int k = 1; k < interval; k++) {
    cloud->points[i-k].normal_z = 1.0;
    pointsNonFeature->points.push_back(cloud->points[i-k]);
    cloud->points[i+k].normal_z = 1.0;
    pointsNonFeature->points.push_back(cloud->points[i+k]);
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant