Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for screenshot naming #78

Closed
goyalyashpal opened this issue Jun 4, 2021 · 3 comments · Fixed by #79
Closed

Suggestion for screenshot naming #78

goyalyashpal opened this issue Jun 4, 2021 · 3 comments · Fixed by #79

Comments

@goyalyashpal
Copy link
Contributor

goyalyashpal commented Jun 4, 2021 •
edited
Loading

image

The much much more predictable naming pattern is just plain consecutive numbers. it helps in lots of corner bug cases.
https://github.com/LonamiWebs/Klooni1010/tree/master/fastlane/metadata/android/en-US/images/phoneScreenshots
@Lonami
Copy link
Member

Lonami commented Jun 4, 2021

What bugs?

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Jun 4, 2021 •
edited
Loading

not the bug in ur app, but the bugs while browsing in fdroid website/client app etc. like today, i couldnt make it to go to 3rd screenshot.

And also, since fdroid web doesnt provide the dedicated image viewer for the screenshot, the predictable naming will also help when screenshots are opened in new tab --> just change the link from 1, to 2, to 3, and done.

@Lonami
Copy link
Member

Lonami commented Jun 4, 2021

Would you like to send a pull request?

@goyalyashpal goyalyashpal mentioned this issue Jun 5, 2021
Merged
@Lonami Lonami closed this as completed in #79 Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed Screenshots
2 participants
@Lonami @goyalyashpal