Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble getting started with the example project #5

Open
andybak opened this issue Oct 10, 2020 · 2 comments
Open

Trouble getting started with the example project #5

andybak opened this issue Oct 10, 2020 · 2 comments

Comments

@andybak
Copy link

andybak commented Oct 10, 2020

FIrstly - Unity won't allow you to open scene files that are installed via UPM so I copied the examples to my assets directory. At this point I got errors because of duplicate names. I closed Unity, removed the examples entry from packages.json and restarted.

However - the example scenes seemed to have lost references and nothing worked.

Personally speaking, I'd recommend publishing the example as a full Unity project. It's a much more reliable way to distribute working code and the presence of a ProjectSettings directory will clarify which Unity version it's expected to work with.

Another issue is the use of Odin. It appears to only be used for inspector buttons and could probably be replaced with https://github.com/dbrizov/NaughtyAttributes which has the same functionality and is open source.

I'm still interested in trying Graphene so any pointers on fixing the issues above would be gratefully received. I'm happy to contribute PRs wherever that would be helpful but I need to get the examples working before I can be much use in that department.

@LudiKha
Copy link
Owner

LudiKha commented Oct 12, 2020

Hi @andybak ! I'll heed your advice and split up the online demo from the sample project, and provide the latter in the form of a Unity Project.

I also experience the lost references issue - unfortunately this seems to be an issue with Unity git packages that are re-imported (e.g. by upgrading to a different version) whilst the editor is open. Restarting the editor has always fixed this issue for me, but I agree it is something that needs to be figured out structurally.

The Odin issue has since been resolved, thanks for bringing it to my attention. Very happy to hear you're willing to contribute. I'll keep you posted with the changes!

@LudiKha
Copy link
Owner

LudiKha commented Oct 21, 2020

Hi @andybak - sorry for the long wait. I've started working on improving the usability of the project this week, including its documentation. You can find the new sample project under the following repo:

https://github.com/LudiKha/Graphene-Sample-Project

It should be plug & play. I'll be updating the documentation further this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants