Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why using id ? #32

Open
Shuunen opened this issue Nov 29, 2016 · 4 comments
Open

Why using id ? #32

Shuunen opened this issue Nov 29, 2016 · 4 comments

Comments

@Shuunen
Copy link

Shuunen commented Nov 29, 2016

Hi :)

All is in the title, why using id on line 29 :
https://github.com/LukyVj/Colorify.js/blob/master/scripts/colorify.js#L29

And in the examples in doc :
image
image
image

Regards.

@LukyVj
Copy link
Owner

LukyVj commented Nov 29, 2016

Hey, thanks for the issue.
Where ?
For each gradient ?

Just because it makes sense to me. But happy to discuss about it :)

@Shuunen
Copy link
Author

Shuunen commented Nov 29, 2016

yes i'm just wondering :) each call to colorify should have an id ?

@LukyVj
Copy link
Owner

LukyVj commented Nov 29, 2016

Ok so, I will have to respond to that a bit later. I did this project nearly 1 year ago, and I barely put my hands in the code after that :p

There were a V2 in it's way, but I stopped developing it.
I have to first dig in my code, and then I'll respond.

But so far, what I can say is I target each 'gradient's target' with ID's.

@Shuunen
Copy link
Author

Shuunen commented Nov 29, 2016

ok :p

it's not a big deal, I was just curious,

Thanks for your lib anyway 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants