Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bindings/python project's setup and organization #226

Open
Martinsos opened this issue Sep 4, 2024 · 0 comments
Open

Improve bindings/python project's setup and organization #226

Martinsos opened this issue Sep 4, 2024 · 0 comments

Comments

@Martinsos
Copy link
Owner

Martinsos commented Sep 4, 2024

I don't have much experience with Python, especially the packaging/building + some time has passed since I first created this Python package, so it would be great to revise and modernize the setup / organization of bindings/python package. Fix old mistakes and make sure we use latest best practices.

What I know is that I am currently using Makefile for, but I should probably instead be using setup.py and pyproject.toml for most of this work, as much of it as possible. I should look into that, if I can get rid of Makefile, then other stuff might also work smoother. And then also I can somewhere properly declare which are the deps that python binding uses (for dev), instead of installing one by one in the makefile -> in requirements.txt or maybe in pyproject.toml if that is a better way today.

It might also make sense to reconsider which builder to use. Poetry is popular these days.

Help here is very welcome from experienced Pythonistas!

NOTE: this python package uses edlib cpp library that is plugged in via Cython. This adds some complexity. Also, we are using cibuildwheels to build the wheels in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant