Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🗃]: Shift Right clicking book piles to pick books up does not merge books with other book itemstacks in your inventory #1148

Open
thelegitdolt opened this issue Oct 10, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@thelegitdolt
Copy link

8mb.video-EtA-0wVeoGcJ.mp4

Please make them merge using player.getInventory().add() or something like that, it would make working with these blocks ten times easier

@thelegitdolt thelegitdolt added the enhancement New feature or request label Oct 10, 2024
@MehVahdJukaar
Copy link
Owner

I'm actually more annoyed by the block vanishing for a split second

@thelegitdolt
Copy link
Author

but are you annoyed by the issue

@MehVahdJukaar
Copy link
Owner

its a deeper issue than this. so many modded blocks work like that, like hourglass, pedestals, flower pots and such. The first slot they target is the hand that's used. Thing is some vanilla blocks like flower pot wok like that too, probably even armor stand

@thelegitdolt
Copy link
Author

armor stands are fine because armor can't stack

I think you should make it so the all those other blocks use this system too. Farmer's Delight cooking pot works like this and it generally just makes things much easier

@thelegitdolt
Copy link
Author

i would love for this to be a config option at least

@MehVahdJukaar
Copy link
Owner

so i looked at this and it is something that i feel would be beneficial in some circumstances but not in othes. say from example you extract a sword from a pedestal, you expect it to land in your hand, same if you extract a particular book from a book pile. I'll see what i can do but its trickier than it seems

@thelegitdolt
Copy link
Author

I think something like a pedestal is fine since it holds unstacakbles, but having to right click books and having 4 separate books stacks in your inventory is kind of terrible

@thelegitdolt
Copy link
Author

books should also match the behavior of vanilla chiseled bookshelves, which will merge books with the ones in your inventory

@Xelbayria Xelbayria changed the title Shift Right clicking book piles to pick books up does not merge books with other book itemstacks in your inventory [🗃]: Shift Right clicking book piles to pick books up does not merge books with other book itemstacks in your inventory Nov 15, 2024
@thelegitdolt
Copy link
Author

m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants