Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞]: Supplementaries installing with C2ME cannot release thread when shutting down server. #1358

Closed
5 tasks done
RookiesTwo opened this issue Feb 11, 2025 · 7 comments
Closed
5 tasks done
Labels
1.21.1 Minecraft Version bug Something isn't working server related to Server, not Client side.

Comments

@RookiesTwo
Copy link

RookiesTwo commented Feb 11, 2025

Before Continuing:

  • Check you are using the latest version of the mods and its dependencies
  • Always include a latest.log if you are crashing
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version

1.21.1-NEOFORGE

Supplementaries Version

neoforge_1.21-3.0.35-beta

Moonlight Lib Version

moonlight-1.21-2.17.21-neoforge

Describe Issue

Supplementaries installing with C2ME cannot release thread when shutting down server.

When installing C2ME and supplementaries together the issue happens.

I used All the leaks to checked the threads not released:
Image

RelativityMC/C2ME-neoforge#7

@RookiesTwo RookiesTwo added the bug Something isn't working label Feb 11, 2025
@github-actions github-actions bot added 1.21.1 Minecraft Version server related to Server, not Client side. labels Feb 11, 2025
@MehVahdJukaar
Copy link
Owner

MehVahdJukaar commented Feb 11, 2025

Im not sure what is happeing there because i do clear their references on level unload and, using foge ServerStoppedEvent i call LevelEevnt.Unload just the same as forge itself does with its own fake level stuff.
The fact that it doesnt happen without C2me could indicate that its something to do with it

@MehVahdJukaar
Copy link
Owner

is this still an issue?

@RookiesTwo
Copy link
Author

yes, this is still an issue. i can reproduce this with Supplementaries and C2ME installed.
Supplementaries version:neoforge_1.21-3.0.35-beta

while it doesnt happen without C2ME

@MehVahdJukaar
Copy link
Owner

and is moonlight updated?

@RookiesTwo
Copy link
Author

yes, moonlightlib version is 1.21-2.17.26 neoforge.
i also tried delete all other mods ,only left moonlight lib , supplementaries, C2ME and AllTheLeaks, the issue still happen

Minecraft 1.21.1 (minecraft)
Moonlight Lib 1.21-2.17.26 (moonlight)
NeoForge 21.1.115 (neoforge)
Supplementaries 1.21-3.0.35-beta (supplementaries)

Image

@MehVahdJukaar
Copy link
Owner

MehVahdJukaar commented Feb 15, 2025

so to be clear with just all the leaks and NOT C2ME it doesnt happen?

@RookiesTwo
Copy link
Author

so to be clear with just all the leaks and NOT C2ME it doesnt happen?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Minecraft Version bug Something isn't working server related to Server, not Client side.
Projects
None yet
Development

No branches or pull requests

2 participants