Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put in colorbar for surface_net_shortwave_flux_difference #1138

Merged
merged 6 commits into from
Feb 14, 2025
Merged

put in colorbar for surface_net_shortwave_flux_difference #1138

merged 6 commits into from
Feb 14, 2025

Conversation

BernardClaxton
Copy link
Contributor

@BernardClaxton BernardClaxton commented Feb 12, 2025 •
edited
Loading

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

fixes #1136

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

Coverage

@jfrost-mo jfrost-mo marked this pull request as ready for review February 14, 2025 09:47
jfrost-mo
jfrost-mo approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks sensible to me, happy to approve.

You can now go ahead and merge this is pull request into the trunk (main branch) with the green "Merge pull request" button at the bottom of the page.

BernardClaxton added a commit that referenced this pull request Feb 14, 2025
@BernardClaxton
amended fix for radar_reflectivity_at_1km_above_the_surface #1138
b28f2b7
jfrost-mo
jfrost-mo approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the new variable. Go ahead and merge.

@BernardClaxton BernardClaxton merged commit cfd9d30 into main Feb 14, 2025
8 checks passed
@BernardClaxton BernardClaxton deleted the 1136_colorbar_surface_plot branch February 14, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrost-mo jfrost-mo jfrost-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding missing colorbars to surface plots
2 participants
@BernardClaxton @jfrost-mo