-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump {queued-request,selected-network}-controller #29836
base: main
Are you sure you want to change the base?
chore: Bump {queued-request,selected-network}-controller #29836
Conversation
…to v21 These upgrades revert changes made in a previous major version which would have removed the ability to disable per-dapp selected network. This is not needed here on Extension, but is needed on Mobile. So this commit doesn't have any material effect here but is merely to ensure that extension is using the latest versions of these controllers.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
@metamaskbot update-policies |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [8a2a22e]
Page Load Metrics (1837 ± 171 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
These upgrades revert changes made in a previous major version which would have enabled the Per-Dapp Selected Network feature and removed the ability to disable it. This is not needed here on Extension as this feature is fully integrated, but is needed on Mobile. So this commit doesn't have any material effect here but is merely to ensure that we are using the latest versions of these controllers for parity with Mobile.
Related issues
Fixes #29835.
Fixes #29834.
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist