Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump {queued-request,selected-network}-controller #29836

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Jan 21, 2025

Description

These upgrades revert changes made in a previous major version which would have enabled the Per-Dapp Selected Network feature and removed the ability to disable it. This is not needed here on Extension as this feature is fully integrated, but is needed on Mobile. So this commit doesn't have any material effect here but is merely to ensure that we are using the latest versions of these controllers for parity with Mobile.

Open in GitHub Codespaces

Related issues

Fixes #29835.
Fixes #29834.

Manual testing steps

  1. See that per-dapp selected network and request queuing still works as in previous versions.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…to v21

These upgrades revert changes made in a previous major version which
would have removed the ability to disable per-dapp selected network.
This is not needed here on Extension, but is needed on Mobile. So this
commit doesn't have any material effect here but is merely to ensure
that extension is using the latest versions of these controllers.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Jan 21, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 171 kB metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 137 kB metamaskbot

View full report↗︎

@mcmire mcmire changed the title queued-request-controller -> v9, selected-network-controller -> v21 Bump {queued-request,selected-network}-controller Jan 21, 2025
@mcmire mcmire changed the title Bump {queued-request,selected-network}-controller chore: Bump {queued-request,selected-network}-controller Jan 21, 2025
@mcmire
Copy link
Contributor Author

mcmire commented Jan 21, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcmire mcmire marked this pull request as ready for review January 22, 2025 16:38
@mcmire mcmire requested review from a team as code owners January 22, 2025 16:38
@metamaskbot
Copy link
Collaborator

Builds ready [8a2a22e]
Page Load Metrics (1837 ± 171 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint143927661840363174
domContentLoaded142527241811359172
load144127431837356171
domInteractive25176483215
backgroundConnect790272211
firstReactRender16105413014
getState572232110
initialActions01000
loadScripts100721571371320154
setupStore6107293014
uiStartup161330592205437210
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 38.56 KiB (0.65%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@mcmire mcmire enabled auto-merge January 22, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs dev review
3 participants