Remove useExternalServices check for isDecodeSignatureRequestEnabled

[digiwand]

What is this about?

Based on discussion, since the decoder API is an internal service that doesn't send data to any external services, we can remove the useExternalServices check.

decoderAPI should only check useTransactionSimulations

In metamask-controller,

      isDecodeSignatureRequestEnabled: () =>
        this.preferencesController.state.useExternalServices === true &&
        this.preferencesController.state.useTransactionSimulations,

→

      isDecodeSignatureRequestEnabled: () =>
        this.preferencesController.state.useTransactionSimulations,

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

• Engineering (needed in most cases)
• Design
• Product
• QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• Security
• Legal
• Marketing
• Management (please specify)
• Other (please specify)

References

No response