Description

This pull request removes the useExternalServices check from the isDecodeSignatureRequestEnabled function in the metamask-controller.

Reason for the change

The decoder API is an internal service and does not interact with any external services. As a result, the useExternalServices check is unnecessary.

improvement/solution?

• Updated the isDecodeSignatureRequestEnabled function to only check the useTransactionSimulations state.
• This ensures the function logic aligns with the intended design, improving maintainability and reducing unnecessary checks.

Related issues

Fixes: #29847

Manual testing steps

1. Open MetaMask and navigate to the relevant settings page.
2. Enable/disable Transaction Simulations in the preferences.
3. Observe if the decoder functionality behaves as expected.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• [ x ] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• [ x ] I've completed the PR template to the best of my ability
• [ x ] I’ve included tests if applicable
• [ x ] I’ve documented my code using JSDoc format if applicable
• [ x ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [ x ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ x ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.