Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Enhance Snap home page #29765

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: Enhance Snap home page #29765

wants to merge 1 commit into from
+111 −120

Conversation

hjetpoluru
Copy link
Contributor

@hjetpoluru hjetpoluru commented Jan 16, 2025 •
edited
Loading

Description

This PR is to enhance Snap home page

  • Migrated the Snap home page to POM

Open in GitHub Codespaces

Related issues

Fixes: #29895

Manual testing steps

Below command for execution against chrome browser
yarn build:test:flask
yarn test:e2e:single test/e2e/snaps/test-snap-homepage.spec.ts --browser=chrome
Below command for execution against firefox browser
yarn build:test:flask:mv2
ENABLE_MV3=false yarn test:e2e:single test/e2e/snaps/test-snap-homepage.spec.ts --browser=firefox

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@hjetpoluru hjetpoluru self-assigned this Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added team-extension-platform INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 16, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [5742040]
Page Load Metrics (1615 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14812066161614067
domContentLoaded14392020158612962
load14512025161512761
domInteractive227938189
backgroundConnect66523199
firstReactRender1593402914
getState54211115
initialActions01000
loadScripts10601534117211756
setupStore65618199
uiStartup17122297190416378
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -716 Bytes (-0.01%)

@hjetpoluru hjetpoluru changed the title test: Enhance Snap home page(draft) test: Enhance Snap home page Jan 23, 2025
@hjetpoluru hjetpoluru marked this pull request as ready for review January 23, 2025 20:24
@hjetpoluru hjetpoluru requested a review from a team as a code owner January 23, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiergarciavera javiergarciavera javiergarciavera approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@hjetpoluru hjetpoluru

Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-extension-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate the home page to POM
3 participants
@hjetpoluru @metamaskbot @javiergarciavera