From f1ef6b769cab6a5a1fba655e2784fea90640b557 Mon Sep 17 00:00:00 2001 From: davidparizek <101632765+davidparizek@users.noreply.github.com> Date: Thu, 11 Apr 2024 10:44:18 +0200 Subject: [PATCH 01/17] Update inventory.md The currencyCode within the same rate should always have the same currency code. --- channel-manager-operations/inventory.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/channel-manager-operations/inventory.md b/channel-manager-operations/inventory.md index 3474c5d..a35473c 100644 --- a/channel-manager-operations/inventory.md +++ b/channel-manager-operations/inventory.md @@ -49,14 +49,14 @@ Mews always pushes both `gross` and `net` prices, the channel manager chooses wh { "grossAmount": 100.0, "netAmount": 100.0, - "currencyCode": "USD", + "currencyCode": "EUR", "guestCount": 1, "ageCategoryCode": "Adult" }, { "grossAmount": 100.0, "netAmount": 100.0, - "currencyCode": "USD", + "currencyCode": "EUR", "guestCount": 2, "ageCategoryCode": "Child" } From 05f3627b4d1acd128d181e500463c2ed64446faa Mon Sep 17 00:00:00 2001 From: Mike Adams Date: Mon, 22 Apr 2024 11:00:12 +0100 Subject: [PATCH 02/17] corrected error response descriptions --- changelog/README.md | 3 +++ guidelines/responses.md | 35 ++++++++++++++++++++++++++++------- 2 files changed, 31 insertions(+), 7 deletions(-) diff --git a/changelog/README.md b/changelog/README.md index 5dfe519..cff4e3c 100644 --- a/changelog/README.md +++ b/changelog/README.md @@ -1,5 +1,8 @@ # Changelog +## 22nd April 2024 +* Corrected error response descriptions and provided an additional example in [Guidelines > Responses](../guidelines/responses.md). + ## 11th April 2024 * Added loyalty info to Request in [Channel manager API Operations: Process Availability block](../channel-manager-operations/availabilityBlock.md#availability-blockp). diff --git a/guidelines/responses.md b/guidelines/responses.md index f5d763d..9700a5e 100644 --- a/guidelines/responses.md +++ b/guidelines/responses.md @@ -1,10 +1,9 @@ # Responses -Each API request is expected to return a response. The **HTTP status code** of the response is `200` in case the API request processing is successful as well as if the API request processing fails, e.g. if there is an error during reservation processing, or an inventory update message fails validation. -In case of such failures, details about the error are provided in the response body. +Every API request is expected to yield a response. The HTTP status code of the response is `200`. This is true regardless of whether the API request processing is successful, or if it fails, e.g. due to errors during reservation processing or validation of an inventory update message. In the event of a failure, the response body contains details about the error. -> **Important:** In the case of errors with rate codes or category codes, details of the affected codes must be returned in the response body. -> These codes will also be unsynchronized, i.e. disabled. +> **Important:** In the event of errors involving rate codes or category codes, details of the affected codes must be returned in the response body. +> These codes will also be unsynchronized as a result of the error, i.e. disabled. ## Synchronous simple response @@ -19,8 +18,9 @@ This response object represents the default response, in case of success. ## Synchronous error response -In case of error, the response object will extend the simple response object with details about the error. -In case of errors with rate codes or category codes, details of the affected codes must also be returned. +In case of error, the response object will extend the simple response object with details about the error or errors. +Use the singular form `error` for a single error, and use the plural form `errors` for multiple errors. +In case of any errors with rate codes or category codes, details of the affected codes must also be returned. See the [Error codes](#error-codes) table below for further details about specific errors, including guidance on system behaviour. ### Example \#1 @@ -61,11 +61,32 @@ See the [Error codes](#error-codes) table below for further details about specif } ``` +### Example \#4 + +```javascript +{ + "success": false, + "errors":[ + { + "code":9, + "message":"Invalid rate code", + "rateCode":"ABC" + }, + { + "code":10, + "message":"Invalid category code", + "categoryCode":"XYZ" + } + ] +} +``` + | Property | Type | Contract | Description | | :-- | :-- | :-- | :-- | | `success` | `bool` | required | Determinines the result of the operation. | | `asyncConfirmation` | `bool` | optional | Determinines if there will be following asynchronous response. | -| `errors` | array of [`Error`](#error) | optional | In case of `"success": false`, this property holds information about the errors that occurred. | +| `error` | [`Error`](#error) | optional | In case of `"success": false`, this property holds information about the error that occurred. The singular form `error` should be used for a single error. | +| `errors` | array of [`Error`](#error) | optional | In case of `"success": false`, this property holds information about the errors that occurred. The plural form `errors` should be used for multiple errors. | ### Error From ef9c319b0b1ed45db5c02129244f4cda7a410602 Mon Sep 17 00:00:00 2001 From: Ondra Hermanek Date: Mon, 13 May 2024 08:53:18 +0200 Subject: [PATCH 03/17] payment type obsolete --- mews-operations/configuration.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mews-operations/configuration.md b/mews-operations/configuration.md index 0759ace..4b7fbb4 100644 --- a/mews-operations/configuration.md +++ b/mews-operations/configuration.md @@ -423,11 +423,13 @@ This is an example of a _successful_ response. In case an error occurred, the re | `name` | `string` | required | Name of the rate plan. | | `currencyCode` | `string` | required | Three-letter currency code of the rate plan price. | | `description` | `string` | optional | Description of the rate plan. | -| `paymentType` | `int` | required | [`Payment type`](#payment-types) code. | +| `paymentType` | `int` | required | (**Obsolete**) [`Payment type`](#payment-types) code. | | `cancellationPolicies` | [`Cancellation Policy`](#cancellation-policy) collection | optional | Cancellation policies of the rate plan. | | `isSynchronized` | `bool` | required | Determines whether rate plan is synchronized, i.e. that Mews pushes prices and restrictions for the rate plan. Otherwise, unsynchronized rate plan is used just for mapping correct rate plan for incoming reservations (as well as sychronized rate plan). | | `rateType` | `int` | required | Determines whether rate plan is private (available for channel reservations only) or public (bookable via Mews Distributor as well). | +> **paymentType**: We're introducing enhancements that elevate settlement rules to the enterprise level, allowing them to be assigned either to a rate group or directly to a rate. Due to the complex nature of settlement rules, which can vary within a rate group, the payment type in getConfiguration endpoint is now obsolete as the value may vary during the time, which is not reflected in this field. + #### Payment types | Code | Description | Notes | From 9d008f8992bf481bbfdbb6ec660b5c77a38c1b4a Mon Sep 17 00:00:00 2001 From: Mike Adams Date: Wed, 15 May 2024 14:53:29 +0100 Subject: [PATCH 04/17] updated Synchronous error response and added new deprecation --- changelog/README.md | 5 +++-- deprecations/README.md | 1 + guidelines/responses.md | 47 ++++++++++++++++++++++------------------- 3 files changed, 29 insertions(+), 24 deletions(-) diff --git a/changelog/README.md b/changelog/README.md index cff4e3c..7f6a512 100644 --- a/changelog/README.md +++ b/changelog/README.md @@ -1,7 +1,8 @@ # Changelog -## 22nd April 2024 -* Corrected error response descriptions and provided an additional example in [Guidelines > Responses](../guidelines/responses.md). +## 15th May 2024 +* Clarified [Synchronous error response](../guidelines/responses.md#synchronous-error-response) +* Deprecated `error` (singular) in [Synchronous error response](../guidelines/responses.md#synchronous-error-response), use `errors` (plural, array) instead. See [Deprecations](../deprecations/README.md) ## 11th April 2024 * Added loyalty info to Request in [Channel manager API Operations: Process Availability block](../channel-manager-operations/availabilityBlock.md#availability-blockp). diff --git a/deprecations/README.md b/deprecations/README.md index 3045572..12ea92d 100644 --- a/deprecations/README.md +++ b/deprecations/README.md @@ -24,6 +24,7 @@ The table columns have the following meanings: | Feature | Comments | Deprecated | Discontinued | | :-- | :-- | :-- | :-- | +| `error` in [Synchronous error response](../guidelines/responses.md#synchronous-error-response) | Replaced by `errors` (plural) | 15 May 2024 | - | | `channel` in [Process group](../mews-operations/reservations.md#process-group) | Replaced by `sources` | 26 Sep 2022 | - | | `iata` in [Company](../mews-operations/reservations.md#company) in [Process group](../mews-operations/reservations.md#process-group) | Replaced by `iata` in the [Travel Agency](../mews-operations/reservations.md#travel-agency) object | 26 Sep 2022 | - | | `adultCount` and `childCount` in [`Reservation`](../mews-operations/reservations.md#reservation) object in [Process group](../mews-operations/reservations.md#process-group) | Replaced by `guestCounts`; **Requires re-certification** | 29 Apr 2022 | - | diff --git a/guidelines/responses.md b/guidelines/responses.md index 9700a5e..a5e87ef 100644 --- a/guidelines/responses.md +++ b/guidelines/responses.md @@ -18,20 +18,19 @@ This response object represents the default response, in case of success. ## Synchronous error response -In case of error, the response object will extend the simple response object with details about the error or errors. -Use the singular form `error` for a single error, and use the plural form `errors` for multiple errors. -In case of any errors with rate codes or category codes, details of the affected codes must also be returned. -See the [Error codes](#error-codes) table below for further details about specific errors, including guidance on system behaviour. +In case of error, the response object will extend the simple response object with details about the error or errors. In case of any errors with rate codes or category codes, details of the affected codes must also be returned. See the [Error codes](#error-codes) table below for further details about specific errors, including guidance on system behaviour. ### Example \#1 ```javascript { "success": false, - "error":{ - "code":8, - "message":"Invalid 'clientToken' or 'connectionToken'." - } + "errors":[ + { + "code":8, + "message":"Invalid 'clientToken' or 'connectionToken'." + } + ] } ``` @@ -39,12 +38,14 @@ See the [Error codes](#error-codes) table below for further details about specif ```javascript { - "success":false, - "error":{ - "code":9, - "message":"Invalid rate code", - "rateCode":"ABC" - } + "success": false, + "errors":[ + { + "code":9, + "message":"Invalid rate code", + "rateCode":"ABC" + } + ] } ``` @@ -52,12 +53,14 @@ See the [Error codes](#error-codes) table below for further details about specif ```javascript { - "success":false, - "error":{ - "code":10, - "message":"Invalid category code", - "categoryCode":"XYZ" - } + "success": false, + "errors":[ + { + "code":10, + "message":"Invalid category code", + "categoryCode":"XYZ" + } + ] } ``` @@ -85,8 +88,8 @@ See the [Error codes](#error-codes) table below for further details about specif | :-- | :-- | :-- | :-- | | `success` | `bool` | required | Determinines the result of the operation. | | `asyncConfirmation` | `bool` | optional | Determinines if there will be following asynchronous response. | -| `error` | [`Error`](#error) | optional | In case of `"success": false`, this property holds information about the error that occurred. The singular form `error` should be used for a single error. | -| `errors` | array of [`Error`](#error) | optional | In case of `"success": false`, this property holds information about the errors that occurred. The plural form `errors` should be used for multiple errors. | +| ~~`error`~~ | ~~[`Error`](#error)~~ | ~~optional~~ | ~~In case of `"success": false`, this property holds information about the error that occurred.~~ **[Deprecated!](../deprecations/README.md)** | +| `errors` | array of [`Error`](#error) | optional | In case of `"success": false`, this property holds information about the error or errors that occurred. | ### Error From ff4d0cfc09a61450d74bc740110abc35c65ecc95 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Wed, 15 May 2024 21:06:30 +0200 Subject: [PATCH 05/17] CR --- deprecations/README.md | 3 +++ mews-operations/configuration.md | 6 +----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/deprecations/README.md b/deprecations/README.md index 3045572..dc3698d 100644 --- a/deprecations/README.md +++ b/deprecations/README.md @@ -32,6 +32,9 @@ The table columns have the following meanings: | `connectionCode` in all API calls on both Mews side and CHM side | Replaced by `connectionToken` | 10 Jan 2018 | End Mar 2018 | | `code` in [`Connection Info`](../mews-operations/configuration.md#connection-info) object in [Get properties](../mews-operations/configuration.md#get-properties) | Replaced by `token` | 10 Jan 2018 | End Mar 2018 | | `distributor` in [`Reservation`](../mews-operations/reservations.md#reservation) object in [Process group](../mews-operations/reservations.md#process-group) | Replaced by `channel` | 10 Jan 2018 | End Mar 2018 | +| `paymentType` in [`RatePlan`](../mews-operations/configuration.md#rate-plan) | May yield incorrect value. More info bellow (1). | 15 May 2024 | - | + +> **(1) paymentType**: We're introducing enhancements that elevate settlement rules to the enterprise level, allowing them to be assigned either to a rate group or directly to a rate. Due to the complex nature of settlement rules, which can vary within a rate group, the `paymentType` is now obsolete as the value may vary depending on reservation dates, which can't be reflected in this field. ## Deprecated functionality diff --git a/mews-operations/configuration.md b/mews-operations/configuration.md index 4b7fbb4..7caec07 100644 --- a/mews-operations/configuration.md +++ b/mews-operations/configuration.md @@ -189,7 +189,6 @@ This is an example of a _successful_ response. In case an error occurred, the re "name": "Non Refundable", "description": "This is our lowest price available. However full payment is required at the time of booking. ", "currencyCode": "EUR", - "paymentType": 1, "isSynchronized": true, "rateType": 1, "cancellationPolicies": [ @@ -214,7 +213,6 @@ This is an example of a _successful_ response. In case an error occurred, the re "name": "Fully Flexible", "description": "This rate is the most flexible rate we offer. Bookings can be cancelled up to 48 hours in advance of your arrival date by 2.30 pm (and 7 days before the arrival dates of the 29th, 30th and 31st of December), without charge. The total price of the reservation will be charged 48 hours before arrival. ", "currencyCode": "EUR", - "paymentType": 3, "isSynchronized": false, "rateType": 1, "cancellationPolicies": [ @@ -423,13 +421,11 @@ This is an example of a _successful_ response. In case an error occurred, the re | `name` | `string` | required | Name of the rate plan. | | `currencyCode` | `string` | required | Three-letter currency code of the rate plan price. | | `description` | `string` | optional | Description of the rate plan. | -| `paymentType` | `int` | required | (**Obsolete**) [`Payment type`](#payment-types) code. | +| ~~`paymentType`~~ | ~~`int`~~ | ~~required~~ | ~~[`Payment type`](#payment-types) code.~~ [**Deprecated**](../deprecations/README.md)| | `cancellationPolicies` | [`Cancellation Policy`](#cancellation-policy) collection | optional | Cancellation policies of the rate plan. | | `isSynchronized` | `bool` | required | Determines whether rate plan is synchronized, i.e. that Mews pushes prices and restrictions for the rate plan. Otherwise, unsynchronized rate plan is used just for mapping correct rate plan for incoming reservations (as well as sychronized rate plan). | | `rateType` | `int` | required | Determines whether rate plan is private (available for channel reservations only) or public (bookable via Mews Distributor as well). | -> **paymentType**: We're introducing enhancements that elevate settlement rules to the enterprise level, allowing them to be assigned either to a rate group or directly to a rate. Due to the complex nature of settlement rules, which can vary within a rate group, the payment type in getConfiguration endpoint is now obsolete as the value may vary during the time, which is not reflected in this field. - #### Payment types | Code | Description | Notes | From 6023a9ccf4186cbe87aa60560f5cb24d6519da47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Wed, 15 May 2024 21:09:12 +0200 Subject: [PATCH 06/17] changelog --- changelog/README.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/changelog/README.md b/changelog/README.md index 0b573a6..b21c10a 100644 --- a/changelog/README.md +++ b/changelog/README.md @@ -1,10 +1,15 @@ # Changelog +## 16th May 2024 + +* Deprecated `paymentType` in [`RatePlan`](../mews-operations/configuration.md#rate-plan), see [Deprecations](../deprecations/README.md). ## 19th April 2024 + * Clarified dates in ARI pushes, Availability blocks and Reservation Push and delivery. ## 11th April 2024 + * Added loyalty info to Request in [Channel manager API Operations: Process Availability block](../channel-manager-operations/availabilityBlock.md#availability-block). ## 26th March 2024 From b60967f8b9ead9139dd385e731711345565c9489 Mon Sep 17 00:00:00 2001 From: Mike Adams <92085514+MikeAdamsMews@users.noreply.github.com> Date: Thu, 16 May 2024 10:25:44 +0100 Subject: [PATCH 07/17] Update README.md moved the deprecations entry to the top (newest are at the top) --- deprecations/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/deprecations/README.md b/deprecations/README.md index dc3698d..2ada626 100644 --- a/deprecations/README.md +++ b/deprecations/README.md @@ -24,6 +24,7 @@ The table columns have the following meanings: | Feature | Comments | Deprecated | Discontinued | | :-- | :-- | :-- | :-- | +| `paymentType` in [`RatePlan`](../mews-operations/configuration.md#rate-plan) returned by [Mews: Get configuration](../mews-operations/configuration.md#get-configuration) | May yield incorrect value. More info below (\*1). | 16 May 2024 | - | | `channel` in [Process group](../mews-operations/reservations.md#process-group) | Replaced by `sources` | 26 Sep 2022 | - | | `iata` in [Company](../mews-operations/reservations.md#company) in [Process group](../mews-operations/reservations.md#process-group) | Replaced by `iata` in the [Travel Agency](../mews-operations/reservations.md#travel-agency) object | 26 Sep 2022 | - | | `adultCount` and `childCount` in [`Reservation`](../mews-operations/reservations.md#reservation) object in [Process group](../mews-operations/reservations.md#process-group) | Replaced by `guestCounts`; **Requires re-certification** | 29 Apr 2022 | - | @@ -32,9 +33,8 @@ The table columns have the following meanings: | `connectionCode` in all API calls on both Mews side and CHM side | Replaced by `connectionToken` | 10 Jan 2018 | End Mar 2018 | | `code` in [`Connection Info`](../mews-operations/configuration.md#connection-info) object in [Get properties](../mews-operations/configuration.md#get-properties) | Replaced by `token` | 10 Jan 2018 | End Mar 2018 | | `distributor` in [`Reservation`](../mews-operations/reservations.md#reservation) object in [Process group](../mews-operations/reservations.md#process-group) | Replaced by `channel` | 10 Jan 2018 | End Mar 2018 | -| `paymentType` in [`RatePlan`](../mews-operations/configuration.md#rate-plan) | May yield incorrect value. More info bellow (1). | 15 May 2024 | - | -> **(1) paymentType**: We're introducing enhancements that elevate settlement rules to the enterprise level, allowing them to be assigned either to a rate group or directly to a rate. Due to the complex nature of settlement rules, which can vary within a rate group, the `paymentType` is now obsolete as the value may vary depending on reservation dates, which can't be reflected in this field. +> **(\*1) paymentType**: We are introducing enhancements that elevate settlement rules to the enterprise level, allowing them to be assigned either to a rate group or directly to a rate. Due to the complex nature of settlement rules, which can vary within a rate group, `paymentType` is now obsolete as the value may vary depending on reservation dates, which can't be reflected in this field. ## Deprecated functionality From 2179f05562e9eba7b8c08ce1dc1326b2cf3bb7cf Mon Sep 17 00:00:00 2001 From: Mike Adams <92085514+MikeAdamsMews@users.noreply.github.com> Date: Thu, 16 May 2024 10:28:22 +0100 Subject: [PATCH 08/17] Update mews-operations/configuration.md --- mews-operations/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mews-operations/configuration.md b/mews-operations/configuration.md index 7caec07..db7addc 100644 --- a/mews-operations/configuration.md +++ b/mews-operations/configuration.md @@ -421,7 +421,7 @@ This is an example of a _successful_ response. In case an error occurred, the re | `name` | `string` | required | Name of the rate plan. | | `currencyCode` | `string` | required | Three-letter currency code of the rate plan price. | | `description` | `string` | optional | Description of the rate plan. | -| ~~`paymentType`~~ | ~~`int`~~ | ~~required~~ | ~~[`Payment type`](#payment-types) code.~~ [**Deprecated**](../deprecations/README.md)| +| ~~`paymentType`~~ | ~~`int`~~ | ~~required~~ | ~~[`Payment type`](#payment-types) code.~~ [**Deprecated!**](../deprecations/README.md)| | `cancellationPolicies` | [`Cancellation Policy`](#cancellation-policy) collection | optional | Cancellation policies of the rate plan. | | `isSynchronized` | `bool` | required | Determines whether rate plan is synchronized, i.e. that Mews pushes prices and restrictions for the rate plan. Otherwise, unsynchronized rate plan is used just for mapping correct rate plan for incoming reservations (as well as sychronized rate plan). | | `rateType` | `int` | required | Determines whether rate plan is private (available for channel reservations only) or public (bookable via Mews Distributor as well). | From 003ed4bc49b438178117c48bb1eeb01ddd9d3b9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Thu, 16 May 2024 11:56:15 +0200 Subject: [PATCH 09/17] Update README.md --- deprecations/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deprecations/README.md b/deprecations/README.md index 6962b69..46f6e7b 100644 --- a/deprecations/README.md +++ b/deprecations/README.md @@ -24,7 +24,7 @@ The table columns have the following meanings: | Feature | Comments | Deprecated | Discontinued | | :-- | :-- | :-- | :-- | -| `error` in [Synchronous error response](../guidelines/responses.md#synchronous-error-response) | Replaced by `errors` (plural) | 15 May 2024 | - | +| `error` in [Synchronous error response](../guidelines/responses.md#synchronous-error-response) | Replaced by `errors` (plural and an `array`) | 15 May 2024 | - | | `paymentType` in [`RatePlan`](../mews-operations/configuration.md#rate-plan) returned by [Mews: Get configuration](../mews-operations/configuration.md#get-configuration) | May yield incorrect value. More info below (\*1). | 16 May 2024 | - | | `channel` in [Process group](../mews-operations/reservations.md#process-group) | Replaced by `sources` | 26 Sep 2022 | - | | `iata` in [Company](../mews-operations/reservations.md#company) in [Process group](../mews-operations/reservations.md#process-group) | Replaced by `iata` in the [Travel Agency](../mews-operations/reservations.md#travel-agency) object | 26 Sep 2022 | - | From c35ba4938baa5907485d14dffa8b95139201bd78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Tue, 11 Jun 2024 11:11:15 +0200 Subject: [PATCH 10/17] Create pr-automation.yml --- .github/workflows/pr-automation.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/workflows/pr-automation.yml diff --git a/.github/workflows/pr-automation.yml b/.github/workflows/pr-automation.yml new file mode 100644 index 0000000..a813b28 --- /dev/null +++ b/.github/workflows/pr-automation.yml @@ -0,0 +1,20 @@ +name: Add every PR to a project and apply distribution label + +on: + pull_request: + branches: [ "master" ] + + # Allows you to run this workflow manually from the Actions tab + workflow_dispatch: + +jobs: + add-to-project: + name: Add To GitHub projects + runs-on: ubuntu-latest + steps: + - uses: actions/add-to-project@v1.0.1 + with: + project-url: https://github.com/orgs/MewsSystems/projects/21 + github-token: ${{ secrets.GITHUB_TOKEN }} + labeled: con.distribution documentation-only + label-operator: AND From 7a7c0c1dfc3e8015e7e0227d01cc6c7eec114205 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Tue, 11 Jun 2024 11:18:48 +0200 Subject: [PATCH 11/17] Update pr-automation.yml --- .github/workflows/pr-automation.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr-automation.yml b/.github/workflows/pr-automation.yml index a813b28..9c5213a 100644 --- a/.github/workflows/pr-automation.yml +++ b/.github/workflows/pr-automation.yml @@ -12,9 +12,13 @@ jobs: name: Add To GitHub projects runs-on: ubuntu-latest steps: + # Add to project - uses: actions/add-to-project@v1.0.1 with: project-url: https://github.com/orgs/MewsSystems/projects/21 - github-token: ${{ secrets.GITHUB_TOKEN }} - labeled: con.distribution documentation-only - label-operator: AND + github-token: ${{ secrets.GITHUB_TOKEN }} + + ## Add label + - uses: christianvuerings/add-labels@v1.1 + with: + labels: con.distribution documenation-only From 6dc19e0d740583bc031ae4e9a67ebb26db9e6cf6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Tue, 11 Jun 2024 11:35:53 +0200 Subject: [PATCH 12/17] Update pr-automation.yml --- .github/workflows/pr-automation.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-automation.yml b/.github/workflows/pr-automation.yml index 9c5213a..68cd83f 100644 --- a/.github/workflows/pr-automation.yml +++ b/.github/workflows/pr-automation.yml @@ -13,10 +13,10 @@ jobs: runs-on: ubuntu-latest steps: # Add to project - - uses: actions/add-to-project@v1.0.1 - with: - project-url: https://github.com/orgs/MewsSystems/projects/21 - github-token: ${{ secrets.GITHUB_TOKEN }} + #- uses: actions/add-to-project@v1.0.1 + # with: + # project-url: https://github.com/orgs/MewsSystems/projects/21 + # github-token: ${{ secrets.GITHUB_TOKEN }} ## Add label - uses: christianvuerings/add-labels@v1.1 From 8620950d34eb8b0955585f9abb878a14067ec388 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Tue, 11 Jun 2024 11:47:16 +0200 Subject: [PATCH 13/17] Update pr-automation.yml --- .github/workflows/pr-automation.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-automation.yml b/.github/workflows/pr-automation.yml index 68cd83f..0d44ce6 100644 --- a/.github/workflows/pr-automation.yml +++ b/.github/workflows/pr-automation.yml @@ -19,6 +19,9 @@ jobs: # github-token: ${{ secrets.GITHUB_TOKEN }} ## Add label - - uses: christianvuerings/add-labels@v1.1 + - uses: actions/checkout@v2 + - uses: tella-adam/add-labels@v1 with: labels: con.distribution documenation-only + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 2396732e8bd048f4996f302c3e601b5f4a402a5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Tue, 11 Jun 2024 11:49:06 +0200 Subject: [PATCH 14/17] Update pr-automation.yml --- .github/workflows/pr-automation.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-automation.yml b/.github/workflows/pr-automation.yml index 0d44ce6..cb43cd3 100644 --- a/.github/workflows/pr-automation.yml +++ b/.github/workflows/pr-automation.yml @@ -6,6 +6,9 @@ on: # Allows you to run this workflow manually from the Actions tab workflow_dispatch: + +env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} jobs: add-to-project: @@ -19,9 +22,6 @@ jobs: # github-token: ${{ secrets.GITHUB_TOKEN }} ## Add label - - uses: actions/checkout@v2 - - uses: tella-adam/add-labels@v1 + - uses: christianvuerings/add-labels@v1.1 with: labels: con.distribution documenation-only - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 376ad046e7d079e4bb3970b846a544e287951945 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Tue, 11 Jun 2024 11:55:04 +0200 Subject: [PATCH 15/17] Update pr-automation.yml --- .github/workflows/pr-automation.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/pr-automation.yml b/.github/workflows/pr-automation.yml index cb43cd3..eb2cbbe 100644 --- a/.github/workflows/pr-automation.yml +++ b/.github/workflows/pr-automation.yml @@ -3,6 +3,7 @@ name: Add every PR to a project and apply distribution label on: pull_request: branches: [ "master" ] + types: [ open, reopen ] # Allows you to run this workflow manually from the Actions tab workflow_dispatch: @@ -22,6 +23,8 @@ jobs: # github-token: ${{ secrets.GITHUB_TOKEN }} ## Add label + - uses: actions/checkout@v2 - uses: christianvuerings/add-labels@v1.1 with: labels: con.distribution documenation-only + issue_number: ${{ github.event.pull_request.number }} From d8b7e23899d50a25b04ef1710193a80a7b253b64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Tue, 11 Jun 2024 12:04:22 +0200 Subject: [PATCH 16/17] Update pr-automation.yml --- .github/workflows/pr-automation.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-automation.yml b/.github/workflows/pr-automation.yml index eb2cbbe..e34e77b 100644 --- a/.github/workflows/pr-automation.yml +++ b/.github/workflows/pr-automation.yml @@ -23,8 +23,9 @@ jobs: # github-token: ${{ secrets.GITHUB_TOKEN }} ## Add label - - uses: actions/checkout@v2 - - uses: christianvuerings/add-labels@v1.1 + - name: Assign QA project + uses: srggrs/assign-one-project-github-action@1.3.1 + if: github.event.action == 'opened' with: - labels: con.distribution documenation-only - issue_number: ${{ github.event.pull_request.number }} + project: 'https://github.com/orgs/MewsSystems/projects/21' + column_name: 'Review' From 23055193718cfbff044319d6de93227422afa946 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondra=20He=C5=99m=C3=A1nek?= Date: Tue, 11 Jun 2024 12:07:25 +0200 Subject: [PATCH 17/17] Update pr-automation.yml --- .github/workflows/pr-automation.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/pr-automation.yml b/.github/workflows/pr-automation.yml index e34e77b..b79d762 100644 --- a/.github/workflows/pr-automation.yml +++ b/.github/workflows/pr-automation.yml @@ -2,8 +2,6 @@ name: Add every PR to a project and apply distribution label on: pull_request: - branches: [ "master" ] - types: [ open, reopen ] # Allows you to run this workflow manually from the Actions tab workflow_dispatch: @@ -23,7 +21,7 @@ jobs: # github-token: ${{ secrets.GITHUB_TOKEN }} ## Add label - - name: Assign QA project + - name: Assign tech.be project uses: srggrs/assign-one-project-github-action@1.3.1 if: github.event.action == 'opened' with: