Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback - Explain token.botframework.com in validDomains and how to support regional bot service #12242

Open
Benjiiim opened this issue Feb 5, 2025 · 4 comments
Assignees
Labels
doc-enhancement If feedback is about suggested improvements/additions, but no evidence customer was blocked. teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label

Comments

@Benjiiim
Copy link
Contributor

Benjiiim commented Feb 5, 2025

Type of issue

Missing information

Feedback

Would you mind documenting in the "To configure app manifest" section that "token.botframework.com" should be added in the validDomains property of the manifest (it is in the example) and explaining if and how this value should be customized based on the location of Azure Bot Service (related to https://learn.microsoft.com/en-us/azure/bot-service/ref-oauth-redirect-urls?view=azure-bot-service-4.0).

Page URL

https://learn.microsoft.com/en-us/microsoftteams/platform/bots/how-to/authentication/bot-sso-manifest

Content source URL

https://github.com/MicrosoftDocs/msteams-docs/blob/main/msteams-platform/bots/how-to/authentication/bot-sso-manifest.md

Author

@surbhigupta

Document Id

5f4e812e-2836-0c23-5b4f-e416ae624372

Copy link
Contributor

Hi Benjiiim! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

@Prasad-MSFT Prasad-MSFT self-assigned this Feb 6, 2025
@Prasad-MSFT Prasad-MSFT added doc-enhancement If feedback is about suggested improvements/additions, but no evidence customer was blocked. teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label and removed needs-triage 🔍 labels Feb 6, 2025
@Prasad-MSFT
Copy link
Collaborator

Prasad-MSFT commented Feb 6, 2025

Hi @surbhigupta12, could you please help adding a note in this documentation section stating that,

Adding token.botframework.com to the validDomains property is necessary for bots that use the Bot Framework to handle authentication and token exchange.
The OAuth URL & OAuth redirect URL to use with your bot and identity provider can be customized based on your data residency requirements and whether your bot is in the public cloud or the Microsoft Azure Government cloud or the Microsoft Azure operated by 21Vianet.
Ref: https://learn.microsoft.com/en-us/azure/bot-service/ref-oauth-redirect-urls?view=azure-bot-service-4.0

@Benjiiim, please feel free to add if i missed anything.

@Benjiiim
Copy link
Contributor Author

Benjiiim commented Feb 6, 2025

Thanks a lot @Prasad-MSFT

To my mind, it would be good to split this improvement in three location:

@Prasad-MSFT
Copy link
Collaborator

Thanks @Benjiiim for your input. Hi @surbhigupta12, need your help here to update the document as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-enhancement If feedback is about suggested improvements/additions, but no evidence customer was blocked. teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label
Projects
None yet
Development

No branches or pull requests

4 participants