Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for anything below iOS 12 #258

Merged
merged 20 commits into from
Mar 20, 2020

Conversation

dive
Copy link
Member

@dive dive commented Mar 10, 2020

Hello there,

Okay, this one is huge in terms of LOC but quite simple (resolved #250).

Main changes

  • Switched to IPHONEOS_DEPLOYMENT_TARGET = 12.0;
  • Fixed all deprecations and warnings due to the migration to iOS 12 as a deployment target;
  • DocumentViewController reimplemented in Swift (PreviewViewController) to get rid of deprecated UIWebView usages;
  • Common build settings for all targets extracted to Global.shared.xcconfig;
  • Removed duplicated options from .xcodeproj;
  • Fixed HTML annotation for a viewport to render HTML properly on mobile devices;
  • Completed the switch to ARC (no more retain/release/etc.);
  • Enabled all useful Clang warnings/checks and fixed all consequences.

Regression

There was a feature to restore the scroll position within the HTML that was opened in the previous sessions but, after some checks, I realised that it never worked as expected. I removed this functionality due to complexity and doubtful benefit. Let me know if I need to restore it.

Disclaimer

I have tested all possible scenarios, check everything with Leaks & Performance profiles and did not notice any problems (or they were fixed within the branch). My only concern that there can be something wrong with the distribution to the AppStore. Let me know if this is a case and I will fix it.

@dive dive added the development process Categorizes issue or PR as related to fixing or improving the development process label Mar 10, 2020
@webframp
Copy link
Member

@dive will take time to review this asap, but I agree with the changes for sure. Thanks!

@webframp webframp merged commit 5e3a166 into MobileOrg:develop Mar 20, 2020
@webframp
Copy link
Member

@dive this change is live in TestFlight now. Sorry for the delay, it’s been a crazy couple of weeks and time has flown by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development process Categorizes issue or PR as related to fixing or improving the development process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for anything below iOS 12
2 participants