-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for anything below iOS 12 #258
Merged
webframp
merged 20 commits into
MobileOrg:develop
from
dive:drop_support_for_ios_below_12
Mar 20, 2020
Merged
Drop support for anything below iOS 12 #258
webframp
merged 20 commits into
MobileOrg:develop
from
dive:drop_support_for_ios_below_12
Mar 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, removed duplicates for settings from .xcodeproj
This reverts commit 47a40dd.
dive
added
the
development process
Categorizes issue or PR as related to fixing or improving the development process
label
Mar 10, 2020
@dive will take time to review this asap, but I agree with the changes for sure. Thanks! |
@dive this change is live in TestFlight now. Sorry for the delay, it’s been a crazy couple of weeks and time has flown by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
development process
Categorizes issue or PR as related to fixing or improving the development process
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
Okay, this one is huge in terms of LOC but quite simple (resolved #250).
Main changes
IPHONEOS_DEPLOYMENT_TARGET = 12.0
;DocumentViewController
reimplemented in Swift (PreviewViewController
) to get rid of deprecatedUIWebView
usages;Global.shared.xcconfig
;.xcodeproj
;Regression
There was a feature to restore the scroll position within the HTML that was opened in the previous sessions but, after some checks, I realised that it never worked as expected. I removed this functionality due to complexity and doubtful benefit. Let me know if I need to restore it.
Disclaimer
I have tested all possible scenarios, check everything with Leaks & Performance profiles and did not notice any problems (or they were fixed within the branch). My only concern that there can be something wrong with the distribution to the AppStore. Let me know if this is a case and I will fix it.